Tags: HugoDorfling/redwood
Tags
fix(server-file): prefix `MODULE_NOT_FOUND` with `ERR_` (redwoodjs#9372) If you try to `await import` a module and it can't be found, it turns out Node throws a different error than if you try to `require` a module and it can't be found: - `require(mod)` -> `MODULE_NOT_FOUND` - `await import(mod)` -> `ERR_MODULE_NOT_FOUND` We used to tranpsile `await import`s to `require`. When we stopped doing that, we forgot to change the error codes we were checking.
fix(api-sever): stop infinite loop on large projects (redwoodjs#9270) Fixes redwoodjs#9237, using @shivghai's solution. At first I thought this solution was (borrowing his term) kludgy because we didn't know why it was happening. But after a few hours I was able to reproduce it on my machine in an app that wasn't his. (I think) I was able to isolate the problem to the `transpileApi` step, which uses esbuild's `buildSync` method. This actually writes to disk, populating the `api/dist` directory. This must happen so slowly on his project that the "change" event from the original filesystem change becomes separate from the "addDir" event. (The more details I go into, the more I'm speculating, so I'll stop there for now.) All I can say is that at first we thought this problem was isolated tho Shiv's project and machine, and since I've disproven both, it's a bug. I still think there are "better" solutions, but they require considerably more work. Like 1) diving into the chokidar codebase or esbuild codebase, 3) replacing chokidar with something else like `@parcel/watcher`, or 4) being smarter about building the api so that it's not completely rebuilt every time.
fix(cli): Remove extraneous console.log from debugging (redwoodjs#9188) **Problem** I left in a console.log in redwoodjs#8920 which should have been removed before merging **Changes** 1. Removes the offending console.log
PreviousNext