8000 Add Makefile, tweak actions by silverwind · Pull Request #135 · GiteaBot/gitea-backporter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Makefile, tweak actions #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 13, 2024
Merged

Add Makefile, tweak actions #135

merged 8 commits into from
Jul 13, 2024

Conversation

silverwind
Copy link
Collaborator
@silverwind silverwind commented Jul 13, 2024 •
edited
Loading
  • Add Makefile with dev tasks
  • Clean up action files, remove unnecessary names
  • Rename deno workflow to ci

@silverwind
Copy link
Collaborator Author

Hmm hold on, I will include fmt-check in lint.

@yardenshoham
Copy link
Collaborator

Before merging, why make and not https://docs.deno.com/runtime/manual/tools/task_runner/?

@silverwind
Copy link
Collaborator Author

Ok should be good. All commands are quiet now which eliminates a lot of useless spam like module downloads or how many files were processed but keeps the important stuff. Only tidbit I have is that fmt --check --quiet does not show which files are unformatted with --quiet but it's acceptable as one can just run make fmt.

@silverwind
Copy link
Collaborator Author
silverwind commented Jul 13, 2024 •
edited
Loading

Before merging, why make and not https://docs.deno.com/runtime/manual/tools/task_runner/?

Because I prefer Makefile in all my projects, e.g. I also don't use npm scripts because Makefile is programming-language agnostic and for certain tasks, much more flexible than these json scripts ever can be.

@yardenshoham yardenshoham enabled auto-merge (squash) July 13, 2024 17:54
@yardenshoham yardenshoham merged commit 59bb8f2 into GiteaBot:main Jul 13, 2024
2 checks passed
@silverwind
Copy link
Collaborator Author

Also, Makefile nicely takes care of the globbing issue. In a deno script, one would likely have to detect the running shell because one can't just shopt in zsh for example.

@silverwind silverwind deleted the makeact branch July 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverwind @yardenshoham
3174
0