8000 feat: update project files implemented by WhereIsW4ldo · Pull Request #1494 · GitTools/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update project files implemented #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

WhereIsW4ldo
Copy link
Contributor

I saw that this was supported in the command line tool, but not in the github action.
Here you go!

@arturcic arturcic added this to the v3.x milestone Feb 7, 2025
@arturcic
Copy link
Member
arturcic commented Feb 7, 2025

@WhereIsW4ldo thanks for taking the time,

can you also update the tests:

describe('GitVersion settings', () => {

describe('getExecuteArguments', () => {

the docs:

for azure:

updateAssemblyInfoFilename:

(add one more sample)

for github actions:

updateAssemblyInfoFilename:

and in the definitions:

updateAssemblyInfoFilename:

and

@arturcic arturcic enabled auto-merge February 8, 2025 08:33
Copy link
Member
@arturcic arturcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I moved the examples in the docs to the appropriate section

@arturcic arturcic merged commit b3ad99f into GitTools:main Feb 8, 2025
8 of 9 checks passed
Copy link
Contributor
mergify bot commented Feb 8, 2025

Thank you @WhereIsW4ldo for your contribution!

@WhereIsW4ldo WhereIsW4ldo deleted the feature/update-project-files branch February 8, 2025 11:01
@arturcic arturcic modified the milestones: v3.x, v3.2.x Apr 2, 2025
@gittools-bot
Copy link

🎉 This issue has been resolved in version v3.2.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0