Update Tocca.js #16
Update Tocca.js #16
Conversation
Only trigger a double click event if both clicks were on the correct element.
|
Sorry I do not get it? Could you explain what you are trying to achieve with this pull request? |
|
I seem to have accidentally added two changes rather than one. It should have been one change. I'll explain what I intended. It was to address a bug, in which you can sometimes get a dbltap event when in fact you have tapped on two different elements. You can recreate it like this:
Currently, the code doesn't check whether the second tap was on the same element as the first tap, so it is treated as a dbltap on the second element. I think it should only fire a tbltap event if both taps occurred on the same element. The suggested change checks, on line 133, whether the target was the same. It also adds 'target' to the list of variables on line 154 (now 155). Does that make sense? Would you like me to submit it again as a single change? |
|
Ah ok I got it. But in your pull request you do not check the target element right? Isn't there something missing? |
Previous version mistakenly omitted the change to lines 133/4.
|
I made a mistake - there are changes in two places and I missed one, sorry. I'm not very familiar with git, so I've been fighting with it a little :/ Lines 133 and 134 should read: sendEvent(e.target, ((tapNum === 2)&&(target===e.target)) ? 'dbltap' : 'tap', e);
target= e.target;and Line 155 should read: currX, currY, cachedX, cachedY, tapTimer, timestamp,target;(ie. I have added 'target' to the end). The correct file is this one |
|
Thanks @DanielJMaxwell your patch now was merged and it's in the new Tocca.js 0.1.4 |
Only trigger a double click event if both clicks were on the correct element.