Fail gracefully on platforms where there is no Unicorn framewor 8000 k #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example on s390 platform (bigendian) the Unicorn engine is not available yet, so import unicorn would currently always fail an break the execution.
|
Thank you! Could you add an entry to the changelog too please? |
|
Can you provide the exact error message and pwntools version ( Lines 352 to 355 in e5cd224 So I am surprised to learn that the error needs additional handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example on s390 platform (bigendian) the Unicorn engine is not available yet, so import unicorn would currently always fail an break the execution.