Removed Offset
#324
Merged
Removed Offset
#324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated and added other join tests. Unify knots for polyline.
Removed Offset class and OffsetTests.
|
@cesarecaoduro @d3ssy in this PR was merged this PR #323 |
d3ssy
reviewed
Sep 2, 2021
| Point3 pt1 = joinedCurve.PointAtLength(15); | ||
| Point3 pt2 = joinedCurve.PointAtLength(21.5); | ||
| Point3 pt3 = joinedCurve.PointAtLength(27.5); | ||
| Point3 pt4 = joinedCurve.PointAtLength(35.2); | ||
|
|
||
| // Arrange |
d3ssy
reviewed
Sep 2, 2021
| pt1.Equals(expectedPt1).Should().BeTrue(); | ||
| pt2.Equals(expectedPt2).Should().BeTrue(); | ||
| pt3.Equals(expectedPt3).Should().BeTrue(); | ||
| pt4.Equals(expectedPt4).Should().BeTrue(); |
There was a problem hiding this comment.
Again here we should just do joinedCurve.Equals(expectedCurve) to test for equality, and expectedCurve defined explicitly in Arrange section.
d3ssy
reviewed
Sep 3, 2021
| @@ -197,6 +198,23 @@ public Line Flip() | |||
| return new Line(EndPoint, StartPoint); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Computes the offset of the line. | |||
There was a problem hiding this comment.
Should specify in which direction the offset is created relative to plane?
d3ssy
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR removed the
Offsetclass and moved the offset method into the single curve classes.Related Tickets & Documents
This PR closes #311
Added tests?
Added to documentation?