8000 Parallel streams by tomstitt · Pull Request #16 · GLVis/glvis-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Parallel streams #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2022
Merged

Parallel streams #16

merged 4 commits into from
Sep 8, 2022

Conversation

tomstitt
Copy link
Member
@tomstitt tomstitt commented Aug 3, 2022 •
edited
Loading

Adds support for parallel streams.

glvis-browser-server will now handle messages with the parallel <nproc> <rank> header; when it sees one it will wait for/build a list with 1 message from each rank then jsonify and write the message. The behavior for serial messages remains unchanged.

The live page with look for json array messages (those that start with [) and decode them.

The stream-list messages are repacked into an Emscripten std::vector<std::string> wrapper (StringArray) then passed to the new displayParallelStreams/updateParallelStreams methods. This approach seems non-optimal but it works for now.

The data_type processing has been removed from the web side and now lives in the compiled code.

Depends on GLVis/glvis#235

@tomstitt tomstitt self-assigned this Aug 3, 2022
@tomstitt tomstitt requested review from publixsubfan and tzanio August 3, 2022 17:15
@tomstitt tomstitt changed the title Draft: Parallel streams Parallel streams Aug 3, 2022
@tomstitt tomstitt requested a review from jandrej August 3, 2022 18:31
tzanio
tzanio approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member
@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen cases where this is a bit fragile, but it is a huge improvement already so lets merge it!

@tzanio
Copy link
Member
tzanio commented Sep 2, 2022 •
edited
Loading

@kanye-quest and @jandrej -- are you interested in reviewing?

@tzanio tzanio merged commit fedc1a8 into master Sep 8, 2022
@tzanio tzanio deleted the web-parallel-streams branch September 8, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzanio tzanio tzanio approved these changes

@publixsubfan publixsubfan Awaiting requested review from publixsubfan

@jandrej jandrej Awaiting requested review from jandrej

Assignees

@tomstitt tomstitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomstitt @tzanio @jandrej
0