8000 fix: add Community Development Officer function by Aarhunt · Pull Request #483 · GEWIS/gewisdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add Community Development Officer function #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

fix: add Community Development Officer function #483

merged 1 commit into from
Jun 29, 2025

Conversation

Aarhunt
Copy link
Contributor
@Aarhunt Aarhunt commented Jun 28, 2025

Add the Community Development Officer as a function of the board.

Description

I want to be installed as a board member ideally :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

rinkp
rinkp requested changes Jun 28, 2025
View reviewed changes
Copy link
Member
@rinkp rinkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on main (not merge), do a make translations and then translate it?

rinkp
rinkp requested changes Jun 28, 2025
View reviewed changes
rinkp
rinkp requested changes Jun 28, 2025
View reviewed changes
Copy link
Member
@rinkp rinkp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

If you do the code changes, the language files will follow more or less. I only commented on en.po, but also holds for the other two

@Aarhunt
Copy link
Contributor Author
Aarhunt commented Jun 28, 2025

Something got a bit weird in the rebasing, but should be fixed now

@rinkp rinkp self-requested a review June 28, 2025 19:53
@rinkp
Copy link
Member
rinkp commented Jun 28, 2025

Translation is malfunctioning because of the 'fuzzy'

Example of decision

rinkp
rinkp requested changes Jun 28, 2025
View reviewed changes
Copy link
Member
@rinkp rinkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost fine, if you fix the spelling issue and the fuzzy in the translation file it should work

@Aarhunt Aarhunt requested a review from rinkp June 29, 2025 09:18
rinkp added a commit to Aarhunt/gewisdb that referenced this pull request Jun 29, 2025
@rinkp
fix(translations): Update translation files for GEWISGH-483
231ce69
rinkp added a commit to Aarhunt/gewisdb that referenced this pull request Jun 29, 2025
@rinkp
fix(translations): Update translation files for GEWISGH-483
067f65a
@Aarhunt @rinkp
feat(database): Introduce community development officer
1c55d93 
Board function of the 44th board

fix: add Community Development Officer function

fix(translations): added translations for the function

fix(translations): fixed the translations of the function again

fix(translations): fix translations one more time)

fix(translations): Update translation files for GEWISGH-483
@rinkp
Copy link
Member
rinkp commented Jun 29, 2025

Changes made:

@rinkp rinkp merged commit 7da129a into GEWIS:main Jun 29, 2025
4 checks passed
github-actions bot added a commit that referenced this pull request Jun 29, 2025
@github-actions @rinkp
Deploy docs from 7da129a
034dfe5 
Rink: Merge pull request #483 from Aarhunt/main

feat(database): add Community Development Officer function (44th)

Thanks to @Aarhunt for implementing this

Co-authored-by: Arend <19819601+Aarhunt@users.noreply.github.com>

Co-authored-by: rinkp <rinkp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinkp rinkp rinkp approved these changes

Assignees
No one assigned
Labels
Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aarhunt @rinkp
0