feat(renewal): new public URL #471
Merged
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to cyber attack we (unfortunately) need a new public URL.
rinkp
previously approved these changes
May 20, 2025
|
As discussed, a slight addition to the email contents |
rinkp
approved these changes
May 20, 2025
|
@rinkp thank you for the patch :) |
github-actions bot
added a commit
that referenced
this pull request
May 21, 2025
Tom Udding: Merge pull request #471 from tomudding/feature/new-domain-for-graduate-renewal feat(renewal): new public URL Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caution
Any renewal link that has not been completed must be removed before deploying this change to prevent sending the email again to people who have already completed the action.
Important
APP_URLmust be changed in prod.Due to cyber attack we (unfortunately) need a new public URL. This will be
member.gewis.nl, so the URL changes fromdatabase.gewis.nl/member/renew/{token}tomember.gewis.nl/renew/{token}.Furthermore, we temporarily need a notice in the email:
Related issues/external references
Fixes ABC-2505-335.
Types of changes