ForgeOps-4394 secret manager v2 #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: securit update update go 1.21 update AWS SDK v2 for secrets manager * fix: update docs * fix: run fmt locally * fix: update SHAs * fix: set buildvcs false * fix: revert * fix: remove cancel * fix: update go directives * fix: remove deprecated io/ioutil * fix: set buildvcs to false * fix: add GOFLAGS to the docker context * fix: add more unit tests * fix: re-run createcluster workflow... * fix: update crypto pkg
a983758 to
b716e5a
Compare
paulbsch
approved these changes
May 28, 2024
|
I just noticed this commit also commits the |
|
Good spot @pearj , I'll get this removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick @dnitsch's earlier PR to update secret-agent to work with secret manager v2 but create env var for AWS region so the secretmanager client can read the configured value in the secretagentconfiguration