fix: update create_asset function to handle id and metadata parameters #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/mosaico/assets/factory.pyandtests/assets/test_factory.pyfiles to improve the handling of asset parameters and enhance test coverage. The most important changes include adding support for additional parameters in asset creation and updating test cases to reflect these changes.Enhancements to asset parameter handling:
src/mosaico/assets/factory.py: Added support foridandmetadataparameters in the_merge_params_with_dictfunction to ensure they are included in the asset creation process.Improvements to test coverage:
tests/assets/test_factory.py: Added new test cases for creating assets withpathand updated theidslist to include more descriptive identifiers for the test cases.Closes #46