8000 fix: improve parity between shelf and flutter by mcquenji · Pull Request #983 · Flutterando/modular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: improve parity between shelf and flutter #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 10, 2025
Merged

fix: improve parity between shelf and flutter #983

merged 14 commits into from
Jun 10, 2025

Conversation

mcquenji
Copy link
Contributor
@mcquenji mcquenji commented Jan 2, 2025 •
edited
Loading

Description

This PR aims to make modules written with modular_core to work in shelf and flutter.
Also has #963 merged.

  • Remove dependency overrides in pubspec.yaml review passes

Routing Mechanism Improvements:

Class Enhancements:

These changes collectively enhance the routing capabilities, ensure compatibility with the latest dependencies, and improve the overall code quality and maintainability.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

shelf_modular now uses the same builder methods for binds instead of a getter.

  • [x ] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#963
#968

Raimundo Melo and others added 12 commits July 26, 2024 17:11
mcquenji and others added 2 commits January 3, 2025 12:28
@mcquenji @zssnyder
fix: pop child routes when parent is popped (#2)
e3b07cd 
* Fix: Pop child routes when parent route is popped

* + Added unit test for parent/child route handling

---------

Co-authored-by: zssnyder <zack.s.snyder@gmail.com>
@mcquenji
feat: allow middleware to read requests
7c9f208
@jacobaraujo7 jacobaraujo7 merged commit 8e7a72c into Flutterando:master Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcquenji mcquenji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcquenji @jacobaraujo7
0