8000 Fix: Popping a parent route should also pop all child routes by zssnyder · Pull Request #961 · Flutterando/modular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Popping a parent route should also pop all child routes #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Fix: Popping a parent route should also pop all child routes #961

merged 2 commits into from
Jun 10, 2025

Conversation

zssnyder
Copy link
Contributor
@zssnyder zssnyder commented Jun 4, 2024

Description

This PR is intended to fix issue #960. Additional checks were added when popping from the navigation stack to prevent leaving orphaned navigation routes or modules. These changes ensure all child routes are removed from navigation history and that the enclosing module will be disposed if no other routes from that module exist on the stack.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #960

@jacobaraujo7 jacobaraujo7 merged commit d8c5114 into Flutterando:master Jun 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobaraujo7 jacobaraujo7 jacobaraujo7 approved these changes

Assignees

@zssnyder zssnyder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RouterOutlet routes persist even when parent route is popped
2 participants
@zssnyder @jacobaraujo7
0