Add support for adding titles to asset page graphs #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Belhsan Hmida <149331360+BelhsanHmida@users.noreply.github.com>
Flix6x
reviewed
Jul 17, 2024
Signed-off-by: Mohamed Belhsan Hmida <149331360+BelhsanHmida@users.noreply.github.com>
Signed-off-by: Mohamed Belhsan Hmida <149331360+BelhsanHmida@users.noreply.github.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
nhoening
reviewed
Jul 19, 2024
…Schema and Able to handle both 'sensor' and 'sensors' inputs Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…'sensor' and 'sensors' inputs Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…rs' inputs Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
nd 'sensors' inputs Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
nhoening
requested changes
Aug 13, 2024
There was a problem hiding this comment.
I thought about this, which indeed is a bit tricky, and I hope I helped to resolve how to go forward with this.
It might be helpful to add simple unit tests for validating and deserializing some example input values for sensors_to_show using the new Schema (in flexmeasures/data/schemas/tests)
2 tasks
Flix6x
reviewed
Aug 29, 2024
…set-graphs Integrate latest updates from the main branch into the feature branch. This merge brings in recent changes from the main branch, ensuring compatibility and incorporating any improvements or fixes made to the main codebase.
…event From PR #1162 Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…t axis titles Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…ation Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Flix6x
reviewed
Sep 8, 2024
nhoening
approved these changes
Sep 8, 2024
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Flix6x
reviewed
Sep 11, 2024
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…for 'sensors_to_show' Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
…sts before PR #1162 resolves file changes Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To allow for custom graph titles for sensors input by the user by modifying the
sensors_to_showattribute in the attributes section.Files changed:
flexmeasures/data/models/generic_assets.py:sensors_to_showattribute to accept dictionaries withtitleandsensorkeys orsensors.sensors_to_showwith{'title': 'sensor_title', 'sensor': sensor_id}or{'title': 'sensor_title', 'sensors': List[sensor_ids]}.flexmeasures/data/schema_generic_assets.py:GenericAssetSchemato create seperateSensorsToShowSchema.titleandsensororsensorsfields in the dictionary.flexmeasures/data/models/charts/belief_charts.py:chart_for_multiple_sensorsfunction to handle the new format.flexmeasures/utils/coding_utils.py:flatten_uniquefunction to handle the new format and extract sensor IDs from dictionaries withtitleandsensororsensorskeys.Look & Feel
When
{'title': 'sensor_title', 'sensor': sensor_id}or{'title': 'sensor_title', 'sensors': list[sensor_ids]}is added tosensors_to_show, this will set the custom title for the graph of that sensor.How to test
Manually test different JSON attributes in the edit asset sidebar.
Verify that custom titles are correctly applied to the corresponding sensor graphs.
Further Improvements
[] move the parsing functionality from flatten_unique to SensorsToShowSchema.
[] Add test case.
[] Add documentation and update the change-log for this feature.
Related Items
closes #1119