8000 Implement getAccount RPC method by cabrador · Pull Request #370 · Fantom-foundation/Sonic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement getAccount RPC method #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2024
Merged

Implement getAccount RPC method #370

merged 4 commits into from
Dec 4, 2024

Conversation

cabrador
Copy link
Collaborator
@cabrador cabrador commented Dec 2, 2024

This PR adds getAccount method to the RPC according to this documentation.

Copy of #317 - StorageRoot can now be extracted from WitnessProof

@cabrador cabrador requested a review from kjezek December 2, 2024 12:56
HerbertJordan
HerbertJordan requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator
@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me. For the integration test, I would like to see more strict requirements for accepted results. See comments.

@cabrador cabrador force-pushed the c/get-account branch 2 times, most recently from 1885139 to 0b08126 Compare December 3, 2024 09:22
kjezek
kjezek requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator
@kjezek kjezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. I need some clarifications, and put some ideas for improvemtenis, please have a look

HerbertJordan
HerbertJordan previously approved these changes Dec 3, 2024
View reviewed changes
@cabrador cabrador requested a review from kjezek December 3, 2024 10:32
kjezek
kjezek previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator
@kjezek kjezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot think of advantage querying data, which are already available in the proof, from state, but I do not have to see all details.

kjezek
kjezek previously approved these changes Dec 3, 2024
View reviewed changes
HerbertJordan
HerbertJordan previously approved these changes Dec 3, 2024
View reviewed changes
@cabrador cabrador dismissed stale reviews from HerbertJordan and kjezek via dd98eb9 December 4, 2024 07:56
@cabrador cabrador merged commit 1c1288e into develop Dec 4, 2024
2 checks passed
@cabrador cabrador deleted the c/get-account branch December 4, 2024 11:30
wsodsong pushed a commit that referenced this pull request Jan 20, 2025
@cabrador @wsodsong
Implement getAccount RPC method (#370)
b9545c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerbertJordan HerbertJordan HerbertJordan approved these changes

@kjezek kjezek kjezek left review comments

@jmpike jmpike Awaiting requested review from jmpike jmpike is a code owner

@thaarok thaarok Awaiting requested review from thaarok thaarok is a code owner

@jenikd jenikd Awaiting requested review from jenikd jenikd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabrador @HerbertJordan @kjezek
0