Add conventional tag for all animals #4168
Conversation
|
I've already made a PR to NeoForge neoforged/NeoForge#1596, and if wanted, I can make a PR to the 1.21.2 branch as well |
|
Seems fine to me |
|
What counts as an animal? My point is, being 'animal' is somewhat arbitrary to a degree - I'm not opposed to there being a tag for it, but there would need to be a consensus on what counts. |
|
@CammiePone Can you add a javadoc to the tag on fabric and neo to say the tag is specifically about mobs that extend Animal class? This means bats, cods, spiders, tadpole, and other creatures are excluded from the tag. If this is not what you were looking for with the animal tag, then some rethinking might be needed. Maybe it should be c:breedable for mobs that can be bred. Not restricted to Animal class. Or c:feedable? Or something else |
|
yeah, i can do that when i get home |
| @@ -36,6 +36,10 @@ private ConventionalEntityTypeTags() { | |||
|
|
|||
| public static final TagKey<EntityType<?>> MINECARTS = register("minecarts"); | |||
| public static final TagKey<EntityType<?>> BOATS = register("boats"); | |||
|
|
|||
| /** | |||
| * Tag containing entity types that extend AnimalEntity | |||
There was a problem hiding this comment.
If this is the case, then Tadpole, Bats, Squid, Glow Squid, and all the fish needs to be removed from the tag.
I'm currently working on a mod, and found a sudden need for a tag that included all animals, ideally one that other mods would include their animals in. It doesn't exist in the base game, and this is the next best thing.
As for why I can't just use an
instanceofcheck, it's because I also need to cover players, illagers, villagers, and wandering traders while still allowing the list of acceptable entities to be configurable by the end user. I'm using a tag of my own, and then including players, villagers, and wandering traders explicitly, then using the existingminecraft:illagerstag for all the illagers, and would like to use ac:animalstag for animals.