zebra: Do not show SRv6 locator params when they are set to default #18961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `show running-config`, normally we don't show parameters that are
set to the default value.
However, currently the `node-len` parameter of an SRv6 locator does
not follow this rule, and is shown even when it is set to the default
value.
The following example shows the issue:
```
router# configure
router(config)# segment-routing
router(config-sr)# srv6
router(config-srv6)# locators
router(config-locators)# locator MAIN
router(config-locator)# prefix fcbb:bb01:1::/48
router# show running-config
[...]
segment-routing
srv6
locators
locator MAIN
prefix fcbb:bb01:1::/48 block-len 24 node-len 24
[...]
```
This commit fixes the issue by hiding the `node-len` parameter when it
is set to default.
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
In `show running-config`, normally we don't show parameters that are
set to the default value.
However, currently the `block-len` parameter of an SRv6 locator does
not follow this rule, and is shown even when it is set to the default
value.
The following example shows the issue:
```
router# configure
router(config)# segment-routing
router(config-sr)# srv6
router(config-srv6)# locators
router(config-locators)# locator MAIN
router(config-locator)# prefix fcbb:bb01:1::/48
router# show running-config
[...]
segment-routing
srv6
locators
locator MAIN
prefix fcbb:bb01:1::/48 block-len 24 node-len 24
[...]
```
This commit fixes the issue by hiding the `block-len` parameter when it
is set to default.
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Jafaral
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
show running-config, normally we don't show parameters that are set to the default value.However, currently the
block-lenandnode-lenparameters of an SRv6 locator do not follow this rule, and are shown even when they are set to the default values.The following example shows the issue:
This PR fixes the issue by hiding the
block-lenandnode-lenparameters when they are set to default.