8000 Bmp ribout by lsang6WIND · Pull Request #18719 · FRRouting/frr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bmp ribout #18719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Bmp ribout #18719

wants to merge 18 commits into from
+3,776 −878

Conversation

lsang6WIND
Copy link
@lsang6WIND lsang6WIND commented Apr 24, 2025 •
edited
Loading
  • Integrate PR14847
  • add label to adj out
  • fix adj out withdraw message
  • do not activate addpath by default in bmp
  • add new topotests: adj out vpn prefix, addpath bmp tests

@lsang6WIND lsang6WIND marked this pull request as draft April 24, 2025 15:28
@frrbot frrbot bot added bgp documentation libfrr tests Topotests, make check, etc labels Apr 24, 2025
@frrbot frrbot bot added the bugfix label Apr 24, 2025
@lsang6WIND lsang6WIND force-pushed the bmp-ribout branch 2 times, most recently from 3e835ad to c9e05b9 Compare April 24, 2025 15:52
@github-actions github-actions bot added the rebase PR needs rebase label Apr 24, 2025
@RodrigoMNardi
Copy link
Contributor

ci:rerun

@lsang6WIND lsang6WIND marked this pull request as ready for review May 5, 2025 15:13
@lsang6WIND lsang6WIND force-pushed the bmp-ribout branch 4 times, most recently from 800f742 to 24433cd Compare May 5, 2025 15:36
@lsang6WIND lsang6WIND marked this pull request as draft May 6, 2025 10:06
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts label Jun 2, 2025
@lsang6WIND lsang6WIND force-pushed the bmp-ribout branch 5 times, most recently from e5fa74a to 0cd43fa Compare June 6, 2025 11:27
@lsang6WIND lsang6WIND marked this pull request as ready for review June 6, 2025 11:28
@lsang6WIND lsang6WIND force-pushed the bmp-ribout branch 4 times, most recently from a60a3f9 to 2105dc7 Compare June 12, 2025 07:52
Loïc Sang added 6 commits June 12, 2025 11:29
topotests: fix and add rib out for bmp1 test
253b443 
Fix test: rename pre/post-policy.
Add bmp unicast rib out tests.

Signed-off-by: Maxence Younsi <mx.yns@outlook.fr>
Signed-off-by: Loïc Sang <loic.sang@6wind.com>
topotests: fix and add rib out for bmp2 test
19f9a9b 
Fix bmp2 test: rename pre/post policy.
Add bmp unicast rib out test.

Signed-off-by: Maxence Younsi <mx.yns@outlook.fr>
Signed-off-by: Loïc Sang <loic.sang@6wind.com>
topotests: fix test for bmp3
3f9b575 
- rename pre/post policy
- move step 2 into the step 3 test; additional tests will be added later

Signed-off-by: Maxence Younsi <mx.yns@outlook.fr>
Signed-off-by: Loïc Sang <loic.sang@6wind.com>
topotests: parse post policy in collector
5ea534c 
Parse post policy in bmp collector.

Signed-off-by: Maxence Younsi <mx.yns@outlook.fr>
Signed-off-by: Loïc Sang <loic.sang@6wind.com>
topotests: add ecmp test in bmp1 test
eac066d 
Add add-path to nlri parsing
Add R3ecmp for ecmp tests

Signed-off-by: Maxence Younsi <mx.yns@outlook.fr>
Signed-off-by: Loïc Sang <loic.sang@6wind.com>
bgp_bmp: add label to bmp adj out
3f7adb9 
Signed-off-by: Loïc Sang <loic.sang@6wind.com>
@lsang6WIND lsang6WIND force-pushed the bmp-ribout branch 2 times, most recently from 442e834 to ff9f675 Compare June 12, 2025 11:11
Loïc Sang added 3 commits June 12, 2025 17:04
bgp_bmp: fix adj out withdrawn
12b9670 
The adj out withdrawal was logged as an update.
Use "adj->adv->baa" to determine if it is an update, else it is a
withdrawn.

Signed-off-by: Loïc Sang <loic.sang@6wind.com>
topotests: add vpn adj out in test_bgp_bmp_3
9949599 
Add bmp vpn rib-out tests

Signed-off-by: Loïc Sang <loic.sang@6wind.com>
bgp_bmp: do not send addpath by default
52a8afb 
- When forging the bmp update packet, we have lost about the policy
stage, use "addpath_id != IDALLOC_INVALID" to determine if addpath is
enabled regardless on rx or tx.
- Update topotests.
- Update bgp bmp doc.

Signed-off-by: Loïc Sang <loic.sang@6wind.com>
@lsang6WIND lsang6WIND force-pushed the bmp-ribout branch 12 times, most recently from f932c91 to 6cd60ae Compare June 13, 2025 15:25
Loïc Sang added 2 commits June 16, 2025 09:27
topotests: add addpath bmp log test
2b4a8b7 
Configure prefixes on R2 and R3ecmp, then check the addpath id bmp
log.

Signed-off-by: Loïc Sang <loic.sang@6wind.com>
topotests: fix bmp log message decodes
974b33d 
Parsing bmp log file by cat command output is not reliable.
Let's use python open() and read().

Signed-off-by: Loïc Sang <loic.sang@6wind.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bgp bugfix documentation libfrr master rebase PR needs rebase size/XXL tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsang6WIND @RodrigoMNardi @mxyns
0