8000 Support doc comments and attributes on nested items by saimeunt · Pull Request #7146 · FuelLabs/sway · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support doc comments and attributes on nested items #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2025
Merged

Support doc comments and attributes on nested items #7146

merged 6 commits into from
May 8, 2025

Conversation

saimeunt
Copy link
Contributor
@saimeunt saimeunt commented May 4, 2025

Description

This PR adds support for nested annotations and doc comments.

Closes #6932

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@saimeunt saimeunt requested a review from a team as a code owner May 4, 2025 09:39
@saimeunt saimeunt temporarily deployed to fuel-sway-bot May 4, 2025 09:40 — with GitHub Actions Inactive
@saimeunt saimeunt temporarily deployed to fuel-sway-bot May 4, 2025 12:38 — with GitHub Actions Inactive
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot May 5, 2025 09:38 — with GitHub Actions Inactive
IGI-111
IGI-111 approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM

@IGI-111 IGI-111 requested a review from a team May 5, 2025 09:44
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot May 7, 2025 12:29 — with GitHub Actions Inactive
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) May 8, 2025 04:17
@JoshuaBatty JoshuaBatty merged commit 47c2fc4 into FuelLabs:master May 8, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

Assignees

@saimeunt saimeunt

Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support doc comments and attributes on nested items
3 participants
@saimeunt @JoshuaBatty @IGI-111
0