8000 feat: improve error message in case of insufficient funds by kayagokalp · Pull Request #4762 · FuelLabs/sway · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: improve error message in case of insufficient funds #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2023
Merged

feat: improve error message in case of insufficient funds #4762

merged 5 commits into from
Jul 7, 2023

Conversation

kayagokalp
Copy link
Member
@kayagokalp kayagokalp commented Jul 6, 2023 •
edited
Loading

Description

closes #4043.

Improves error message by stating the failure reason clearly if the reason is insufficient funds. If the transaction is failing due to insufficient funds we are outputing:

Contract id: 0xa8f18533afc18453323bdf17c83750c556916ab183daacf46d7a8d3c633a40ee

Please provide the password of your encrypted wallet vault at "/Users/kayagokalp/.fuel/wallets/.wallet":
Do you accept to sign this transaction with fuel1egx2nvm4395gukm8uyh4zzxdlx3hht9ulu6n67nhwq57zs74camskx7klp [y/N]:y
Error: Deployment failed due to insufficient funds. Please be sure to have enough coins to pay for deployment transaction.

We will have a balance checking mechanism before signing the transaction for test-net which would make this error only visible to manual signers and people that are working against a local node.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added enhancement New feature or request forc-deploy Everything to do with forc-deploy labels Jul 6, 2023
@kayagokalp kayagokalp self-assigned this Jul 6, 2023
@kayagokalp kayagokalp marked this pull request as ready for review July 6, 2023 12:53
@kayagokalp kayagokalp enabled auto-merge (squash) July 6, 2023 12:53
@kayagokalp kayagokalp requested a review from a team July 6, 2023 13:15
@JoshuaBatty JoshuaBatty requested a review from a team July 6, 2023 13:51
@kayagokalp kayagokalp mentioned this pull request Jul 6, 2023
Merged
7 tasks
@JoshuaBatty JoshuaBatty requested a review from a team July 6, 2023 23:43
@kayagokalp kayagokalp merged commit 4660fc9 into master Jul 7, 2023
@kayagokalp kayagokalp deleted the kayagokalp/4043 branch July 7, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@eureka-cpu eureka-cpu eureka-cpu approved these changes

Assignees

@kayagokalp kayagokalp

Labels
enhancement New feature or request forc-deploy Everything to do with forc-deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc deploy improve error message for insufficient coins
3 participants
@kayagokalp @JoshuaBatty @eureka-cpu
0