8000 Bump to v0.37.2 by kayagokalp · Pull Request #4492 · FuelLabs/sway · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump to v0.37.2 #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Bump to v0.37.2 #4492

merged 1 commit into from
Apr 24, 2023

Conversation

kayagokalp
Copy link
Member
@kayagokalp kayagokalp commented Apr 24, 2023

Waiting for:

  1. fix broken installation url, typo #4488 we can get this later on it is not urgent.

@kayagokalp kayagokalp self-assigned this Apr 24, 2023
@kayagokalp kayagokalp marked this pull request as ready for review April 24, 2023 18:50
@kayagokalp kayagokalp requested review from a team April 24, 2023 18:50
@kayagokalp kayagokalp enabled auto-merge (squash) April 24, 2023 18:51
@IGI-111 IGI-111 requested a review from a team April 24, 2023 18:54
@kayagokalp kayagokalp merged commit dc6af91 into master Apr 24, 2023
@kayagokalp kayagokalp deleted the kayagokalp/bump-0.37.2 branch April 24, 2023 20:19
@mitchmindtree
Copy link
Contributor

This release includes quite a few breaking changes (including Mohammad's storage key refactor) and likely should be rolled out under a new minor release, 0.38.0.

I'm unsure if we have the ability to yank 0.37.2, but if we can we should and re-release as 0.38.0 to avoid mysteriously breaking things for users who d epend on 0.37.1.

@mitchmindtree
Copy link
Contributor
mitchmindtree commented Apr 24, 2023

It looks like yanking might not be an option, so we might need to:

  1. Make a branch from 0.37.1.
  2. Create a new patch release from this 0.37.1 as 0.37.3.
  3. Create a new minor release with the 0.37.2 changes as 0.38.0.

mitchmindtree added a commit that referenced this pull request Apr 25, 2023
…nges

Aimed at addressing the following comment:

#4492 (comment)

Currently our bot doesn't make it easy to yank existing releases. Here
we just republish 0.37.1 as 0.37.3 to ensure users updating their sway
repo deps don't consume the breaking changes accidentally included in
0.37.2.
mitchmindtree added a commit that referenced this pull request Apr 25, 2023
See here:

#4492 (comment)

This follows a re-release of 0.37.1 as 0.37.3:

https://github.com/FuelLabs/sway/releases/tag/v0.37.3

The outcome of all this is that ideally, users previously on 0.37.1
will now pull 0.37.3 next time they run `cargo update` and will not
encounter any breakage. Those ready to update can now point to 0.38.0.
mitchmindtree added a commit that referenced this pull request Apr 25, 2023
See here for context:
#4492 (comment)

This follows a re-release of 0.37.1 as 0.37.3:
https://github.com/FuelLabs/sway/releases/tag/v0.37.3

The outcome of all this is that ideally, users previously on 0.37.1 will
now pull 0.37.3 next time they run `cargo update` and will not encounter
any breakage. Those ready to update can point to 0.38.0 after this is
published.

Also runs `cargo update` in order to update deps to their latest patch
release.

---------

Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0