Fix grayscale on sub-images #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9830e1d to
b3485a7
Compare
Ernyoke
approved these changes
Feb 10, 2024
A5F7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that calling
grayscale.Grayscale(andgrayscale.Grayscale16) on sub-images didn't output image I'd expect.I added new acceptance tests that call the grayscale methods on a cropped image. Before this change, it outputted this:
After the change, it outputs this:
I suspect this might be a wider problem but I thought I'd get some validation that this is the right thing to do before proceeding further.