8000 Add clang-tidy yaml report converter by noraz31 · Pull Request #4335 · Ericsson/codechecker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add clang-tidy yaml report converter #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add clang-tidy yaml report converter #4335

merged 1 commit into from
Jan 29, 2025

Conversation

noraz31
Copy link
Collaborator
@noraz31 noraz31 commented Sep 2, 2024 •
edited
Loading

Currently clang-tidy reports are parsed and converted to plist files from the clang-tidy standard outputs. This change adds a new report converter that uses clang-tidy's yaml outputs as inputs for parsing and creating plist files. See #4063

@noraz31 noraz31 force-pushed the clang_tidy_yaml branch 6 times, most recently from bfc6fc9 to 4ce83eb Compare September 3, 2024 13:01
@bruntib bruntib marked this pull request as draft September 17, 2024 17:20
@noraz31 noraz31 force-pushed the clang_tidy_yaml branch 3 times, most recently from 2c5a4ff to 9c6e430 Compare September 23, 2024 21:04
@noraz31 noraz31 marked this pull request as ready for review September 24, 2024 12:15
@dkrupp dkrupp added this to the release 6.25.0 milestone Nov 5, 2024
@dkrupp dkrupp requested a review from cservakt November 5, 2024 14:22
cservakt
cservakt previously requested changes Nov 6, 2024
View reviewed changes
@noraz31 noraz31 force-pushed the clang_tidy_yaml branch 2 times, most recently from 0af9303 to 5c4bb0f Compare January 15, 2025 13:06
dkrupp
dkrupp requested changes Jan 24, 2025
View reviewed changes
Copy link
Member
@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a concrete test case which shows an example where the hash will be different than the original clang-tidy stdout converter

Add clang-tidy yaml report converter
028c2d1 
Currently clang-tidy reports are parsed and
converted to plist files from the clang-tidy
standard outputs. This change adds a new
report converter that uses clang-tidy's yaml
outputs as inputs for parsing and
creating plist files.
@noraz31
Copy link
Collaborator Author
noraz31 commented Jan 28, 2025

Create a concrete test case which shows an example where the hash will be different than the original clang-tidy stdout converter

Looks like this issue occurred earlier due to some differences in filenames/file paths. Unified clang-tidy & clang-tidy-yaml test case no. 3 and added test case no. 7 for both report converters to demonstrate this. The tests were made using the same build directory and filename, and the output files contain the same hashes.

@bruntib bruntib dismissed cservakt’s stale review January 29, 2025 12:39

"Diagnostics" is a mandatory element of the yaml file.

dkrupp
dkrupp approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member
@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruntib bruntib merged commit 92f1af6 into Ericsson:master Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkrupp dkrupp dkrupp approved these changes

@bruntib bruntib bruntib approved these changes

@cservakt cservakt cservakt left review comments

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release 6.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@noraz31 @dkrupp @bruntib @cservakt
0