Tags: Electron-Cash/secp256k1
Tags
[CMAKE] Drop native build dependency on Openssl Summary: By disabling BIP70 and the secp256k1 Openssl tests for the native build, the dependency is gone. Test Plan: cmake -GNinja .. ninja Check in the cmake run for the native build that openssl is no longer searched. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7816
[CMAKE] Make clang-tidy fail the build rather than trying to auto-fix
Summary:
The current behavior when the clang-tidy option is enabled is to attempt
to auto-fix the issues. This is not the best approach:
- It does not work for all the rules;
- It makes other warnings (not auto-fixable) difficult to spot.
This diff changes the behavior to cause clang-tidy to fail the build
when an issue is encountered, by promoting the warnings to errors. This
will prevent the user from missing a warning which is not auto-fixed.
Note: this option could be set in the .clang-tidy configuration file,
but it seems to have a bug and enable all the checks which is not the
expected behavior.
Test Plan:
cmake -GNinja .. \
-DCMAKE_C_COMPILER=clang \
-DCMAKE_CXX_COMPILER=clang++ \
-DENABLE_CLANG_TIDY=ON
ninja all check
Add some braces issues, then:
ninja
Check that the build fail with a clang-tidy error.
Reviewers: #bitcoin_abc, majcosta
Reviewed By: #bitcoin_abc, majcosta
Differential Revision: https://reviews.bitcoinabc.org/D7538
[LINTER] Add a YAML linter Summary: This uses a relaxed rule set for now, which does not enforce a strict number of indentation spaces but instead check the file is consistently indented. The maximum line lenght rule is also disabled to accomodate the scripts in the gitian descriptors. Test Plan: Should return no error: arc lint --everything Revert the changes to the .travis.yml from this diff then run: arc lint and check the indentation errors are catched by the linter. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7358
[CMAKE] Flag the HTML man pages as generated Summary: This prevent them from being shown by default during reviews. Follow-up for feedback from D7252. Test Plan: ninja install-manpages-html Check the @generated marker is present in the files Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7255
[CMAKE] Generate textual coverage report Summary: This will allow the bot to generate remarkup content to be display in a Phabricator panel. Test Plan: ./contrib/teamcity/build-configurations.py build-coverage Check the text report are generated and part of the coverage archive. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7094
[CMAKE] Generate textual coverage report Summary: This will allow the bot to generate remarkup content to be display in a Phabricator panel. Test Plan: ./contrib/teamcity/build-configurations.py build-coverage Check the text report are generated and part of the coverage archive. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7094
[CMAKE] Add the test suite to the log name Summary: This prevents naming collision to occur, e.g. when running with and without upgrade activated. Test Plan: ninja check-bitcoin check-bitcoin-upgrade-activated Check the logs are now available for each test suite variant. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7024
[secp256k1] Do not use unitialized multiset in multiset benchmark Summary: As per title. The compiler might possibly collapse everything based on the fact x is uninitialized, which we do not want. Test Plan: ninja bench-secp256k1 Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D6870
[CMAKE] Fail early if a lib header is missing, remove garbage in version Summary: This diff improves the UX when a library is missing: - If the header is not found, there is no need to search for anything else. `find_package_handle_standard_args()` is the only useful call to indicate the failure with a nice error message. - There is no need to set the version number to some garbage value. If the version cannot be determined it should just remain unset. Test Plan: ninja check Uninstall some library (miniupnpc was used for this test). cmake -GNinja .. Check it fails to find the lib and outputs a meaningful error message (missing header) Reinstall the library, then cmake -GNinja .. # Don't nuke the cache ! Check the lib is now found. ninja check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6545
Update multiset hash benchmark to use get_iters Summary: Also take the opportunity to add it to travis and make the style a bit more consistent. Depends on D6364 Test Plan: ninja bench-secp256k1-multiset Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D6372
PreviousNext