8000 Add swap(circular_buffer_ext&&) (#1068) by helderTZ · Pull Request #1072 · ETLCPP/etl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add swap(circular_buffer_ext&&) (#1068) #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

helderTZ
Copy link
Contributor
@helderTZ helderTZ commented Apr 12, 2025

This change adds an overload for circular_buffer_ext's swap() for rvalue references and a corresponding test.
Closes #1068

@jwellbelove jwellbelove changed the base branch from master to pull-request/#1072-Add-swap(circular_buffer_ext&&)-(#1068) May 5, 2025 18:14
@jwellbelove
Copy link
Contributor

I'm accepting the pull request, but this is part of a much larger issue regarding how _ext containers are moved, which will need to be addressed at some point.

@jwellbelove jwellbelove merged commit 66af2a6 into ETLCPP:pull-request/#1072-Add-swap(circular_buffer_ext&&)-(#1068) May 5, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: add swap(circular_buffer_ext&&) for circular_buffer_ext
2 participants
0