8000 Optional(POD) operator bool explicit by fermentedfly · Pull Request #699 · ETLCPP/etl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optional(POD) operator bool explicit #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

Optional(POD) operator bool explicit #699

merged 1 commit into from
May 31, 2023

Conversation

fermentedfly
Copy link
Contributor

Hi,

I propose to make operator bool() for etl::optional (POD specialization) explicit.
This would align it with the non-POD specialization and prevent some nasty bugs if one (like me) forgets to dereference an optional.

Regards,
Manuel

@jwellbelove jwellbelove merged commit adfaf07 into ETLCPP:development May 31, 2023
@fermentedfly fermentedfly deleted the optional_operator_bool_explicit branch May 31, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fermentedfly @jwellbelove
0