Add rvalue accessors to expected and optional, and update constructors. #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code does not pass the the C++ standard sanity checks. |
…optional-and-update-constructors' into rvalue
|
Finally got them both installed on WSL. Looking into it. |
|
@jwellbelove I believe I've fixed the issues you mentioned. Could you run the analyzers? |
760ff8b
into
ETLCPP:hotfix/#690-add-rvalue-accessors-to-expected-and-optional-and-update-constructors
jwellbelove
added a commit
that referenced
this pull request
May 20, 2023
…s. (#690) * Add rvalue methods to optional and expected. * Fix constructors in expected.h. * Fix sanity checks. --------- Co-authored-by: John Wellbelove <jwellbelove@users.noreply.github.com>
jwellbelove
added a commit
that referenced
this pull request
May 20, 2023
…al-and-update-constructors' of https://github.com/ETLCPP/etl into hotfix/#690-add-rvalue-accessors-to-expected-and-optional-and-update-constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for
unexpectedwas not working properly with the implicit constructorexpected(unexpected<E>)(probably due to CPP23 overload resolution rules), so it has been replaced with copy- and move-versions of constructors that takeTError.