8000 cam6_4_093: Update CAM testing. by brian-eaton · Pull Request #1309 · ESCOMP/CAM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cam6_4_093: Update CAM testing. #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 19, 2025
Merged

Conversation

brian-eaton
Copy link
Collaborator
@brian-eaton brian-eaton commented May 13, 2025

Copy link
Collaborator
@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of my review, I made sure that each ncdata file which resided in the previous version, still resides in the current one. Aside from a couple of duplicates which were removed since the ic_ymd was not 8000 needed, there were no missing files.

<test compset="QPC5" grid="f10_f10_mg37" name="PLB_D_Ln9" testmods="cam/ttrac_loadbal1">
<machines>
<machine name="izumi" compiler="nag" category="aux_cam"/>
<machine name="izumi" compiler="nag" category="prealpha"/>
</machines>
<options>
<option name="comment" >301 plb</option>
<option name="comment" >phys_loadbalance=1; 5 test tracers; end of year</option>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that perhaps the load balance tests (or at least one) should be run on the SE dycore as it is the dycore of the future, while the FV dycore has had discussions about being deprecated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FV dycore is the only one that uses the phys_loadbalance capability. The other dycores all use the version of phys_grid.F90 which Steve implemented to address weak scaling issues and which does not support physics load balancing.

@@ -1853,9 +1855,9 @@ subroutine coefs_init(coefs_file, available_gases, kdist)
minor_limits_gpt_upper
! Send these to RRTMGP as logicals,
! but they have to be read from the netCDF as integers
logical, dimension(:), allocatable :: minor_scales_with_density_lower, &
logical(wl), dimension(:), allocatable :: minor_scales_with_density_lower, &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for curiosity, why does a logical have a type? Isn't it just true/false?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RRTMGP uses the logical kind c_bool from the iso_c_binding module for interoperability with C. The dummy arguments of type logical in the kdist%load function use that kind, so the actual args need to use it as well. NAG is the only compiler we use that distinquishes between c_bool and kind(.true.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants
0