cam6_4_092: MPAS dp_coupling bug fixes #1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuanchihwang
reviewed
May 5, 2025
There was a problem hiding this comment.
Thanks for requesting a review from me, @PeterHjortLauritzen. I have a couple of questions and suggestions for your consideration.
kuanchihwang
approved these changes
May 6, 2025
nusbaume
requested changes
May 10, 2025
There was a problem hiding this comment.
Thanks for the bug-fixes @PeterHjortLauritzen! I do have a couple of questions/change requests, but otherwise it looks good!
| @@ -1,3 +1,36 @@ | |||
| Tag name: cam6_4_??? | |||
There was a problem hiding this comment.
Just a heads-up to @cacraigucar that the ChangeLog will need to be filled out (including the file list) before the PR is merged. Thanks!
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
|
@nusbaume Thank you for the review ... All suggestions have been adopted and committed! |
nusbaume
approved these changes
May 12, 2025
cam6_4_091: Implement support for moving mountain gravity wave scheme in MPAS dycore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
Not able to add @kuanchihwang as a reviewer ...
Please note we need to make this change in CAM-SIMA as well.
Closes #1268
Closes #753