Return correct dims of rotated grid constructed from geom #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalmijn
requested changes
Apr 2, 2025
tests/gis/test_raster.py
Outdated
Comment on lines
14
to
15
| from shapely import Polygon | ||
| from shapely.geometry import LineString, Point, box |
There was a problem hiding this comment.
Why are there two separate import statements here?
There was a problem hiding this comment.
that was an auto import, I merged it with the next one
tests/gis/test_raster.py
Outdated
Comment on lines
574
to
582
| def test_create_rotated_grid_from_geom(): | ||
| coords = [(0, 0), (10, 0), (10, 100), (0, 100), (0, 0)] | ||
| polygon = Polygon(coords) | ||
|
|
||
| # Create a GeoDataFrame | ||
| region = gpd.GeoDataFrame(pd.DataFrame({"id": [1]}), geometry=[polygon]) | ||
| da = create_rotated_grid_from_geom(region, res=1, dec_origin=0, dec_rotation=0) | ||
| expected_shape = (100, 10) | ||
| assert da.raster.shape == expected_shape |
There was a problem hiding this comment.
This results in a regular grid, I guess the point is to test for rotated grids, so maybe add a rotated square as input geometry?
|
dalmijn
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #1121
Explanation
As mentioned the rotated grid creation returned the dimensions flipped as was reported in the docstring. I added a simple test to solidfy which shapes we should return here
General Checklist
mainData/Catalog checklist
data/catalogs/predefined_catalogs.ymlhas not been modified.data_catalog.ymlfiles have been changeddata/changelog.rsthas been updatedLFline endings (done automatically if you usedupdate_versions.py)Additional Notes (optional)
Add any additional notes or information that may be helpful.