bugfix in hydrograph_1d method #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
hboisgon
approved these changes
May 23, 2024
There was a problem hiding this comment.
All good thanks for fixing this @DirkEilander !
It looks like the windows tests are failing for a different reason but we should look into that before we release...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
An index error was raised when the number of peaks varies between stations. This could occur in real data and should be dealt with in the code.
Explanation
Limit the maximum index per station to the number of peaks.
General Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.