8000 Add agree to terms dialog if so configured by hvangeffen · Pull Request #901 · Deltares/fews-web-oc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add agree to terms dialog if so configured #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 12, 2024
Merged

Add agree to terms dialog if so configured #901

merged 9 commits into from
Jun 12, 2024

Conversation

hvangeffen
Copy link
Collaborator
@hvangeffen hvangeffen commented Jun 10, 2024 •
edited
Loading

Currently only shows either the terms of use or the splashscreen

@hvangeffen hvangeffen requested a review from wkramer June 10, 2024 11:29
@hvangeffen hvangeffen self-assigned this Jun 10, 2024
@hvangeffen hvangeffen linked an issue Jun 10, 2024 that may be closed by this pull request
Add agree to terms screen on startup #899
Closed
@hvangeffen hvangeffen force-pushed the 899-add-agree-to-terms-screen-on-startup branch from 9b3efe1 to 8c3d138 Compare June 10, 2024 11:40
@hvangeffen hvangeffen requested review from ceesvoesenek and removed request for wkramer June 11, 2024 10:02
@ceesvoesenek
Copy link
Collaborator

Currently only shows either the terms of use or the splashscreen

Is that the desired behaviour then?

ceesvoesenek
ceesvoesenek reviewed Jun 11, 2024
View reviewed changes
Copy link
Collaborator
@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small points.

Two more important points:

  • Should we be using local storage outside of Pinia stores?
  • Can you update fews-pi-requests, or is this not ready in the backend?

@hvangeffen hvangeffen force-pushed the 899-add-agree-to-terms-screen-on-startup branch from 62976c6 to 9f120c9 Compare June 11, 2024 14:13
@wkramer wkramer merged commit 729f685 into main Jun 12, 2024
7 of 8 checks passed
@wkramer wkramer deleted the 899-add-agree-to-terms-screen-on-startup branch June 12, 2024 14:22
@bogaardt bogaardt changed the title Add agree to terms dialog Add agree to terms dialog if so configured Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceesvoesenek ceesvoesenek ceesvoesenek left review comments

Assignees

@hvangeffen hvangeffen

Labels
rel: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add agree to terms screen on startup
4 participants
@hvangeffen @ceesvoesenek @wkramer @bogaardt
0