8000 Support node with only filterIds by wkramer · Pull Request #673 · Deltares/fews-web-oc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support node with only filterIds #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

wkramer
Copy link
Collaborator
@wkramer wkramer commented Jan 29, 2024

Do not display wms layer and controls.

Test with: FewsWebServices wqps WebOC demo nodes

@wkramer wkramer linked an issue Jan 29, 2024 that may be closed by this pull request
@wkramer wkramer requested review from amarkensteijn and removed request for amarkensteijn January 29, 2024 13:21
@wkramer wkramer requested a review from hvangeffen January 29, 2024 13:54
Copy link
Collaborator
@hvangeffen hvangeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well when clicking around

capabilities.layers.find((l) => l.name === _layers) ??
capabilities.layers[0]
if (_layers === '') {
layerCapabilities.value = undefined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could keep the return here, no need to indent the code for an initial condition check

} catch (error) {
console.error(error)
if (_layers === '') {
legendGraphic.value = undefined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@wkramer wkramer merged commit 0d742fb into main Jan 31, 2024
@wkramer wkramer deleted the 672-support-topology-node-with-only-filterids branch January 31, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support topology node with only filterIds
2 participants
0