[MINPROC-2201] Update ddev metadata validator to only error on required headers #20419

alyssamui2 · 2025-05-30T18:00:56Z

What does this PR do?

Currently, the ddev metadata validator errors if optional headers are missing. This PR is to update the validator logic to be consistent with the actual required headers.

Motivation

https://datadoghq.atlassian.net/browse/MINPROC-2201

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

codecov · 2025-05-30T18:03:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (f32fa4b) to head (e118bf5).
Report is 53 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
active_directory	`93.18% <ø> (ø)`
activemq	`52.80% <ø> (ø)`
activemq_xml	`82.20% <ø> (ø)`
aerospike	`88.83% <ø> (ø)`
airflow	`93.03% <ø> (ø)`
amazon_msk	`89.50% <ø> (ø)`
ambari	`85.75% <ø> (ø)`
apache	`95.08% <ø> (ø)`
appgate_sdp	`93.93% <ø> (ø)`
arangodb	`98.23% <ø> (ø)`
argo_rollouts	`90.00% <ø> (ø)`
argo_workflows	`89.61% <ø> (ø)`
argocd	`87.16% <ø> (-0.07%)`	⬇️
aspdotnet	`100.00% <ø> (ø)`
avi_vantage	`93.83% <ø> (ø)`
aws_neuron	`92.42% <ø> (ø)`
azure_iot_edge	`82.08% <ø> (ø)`
boundary	`100.00% <ø> (ø)`
btrfs	`83.33% <ø> (ø)`
cacti	`87.90% <ø> (ø)`
calico	`84.61% <ø> (ø)`
cassandra	`66.66% <ø> (ø)`
cassandra_nodetool	`93.16% <ø> (ø)`
celery	`95.45% <ø> (ø)`
ceph	`91.35% <ø> (ø)`
cert_manager	`77.41% <ø> (ø)`
cilium	`77.92% <ø> (ø)`
cisco_aci	`89.43% <ø> (-0.16%)`	⬇️
citrix_hypervisor	`87.97% <ø> (ø)`
clickhouse	`94.55% <ø> (ø)`
cloud_foundry_api	`96.11% <ø> (ø)`
cloudera	`99.51% <ø> (ø)`
cockroachdb	`92.98% <ø> (ø)`
confluent_platform	`81.96% <ø> (ø)`
consul	`91.92% <ø> (ø)`
coredns	`95.65% <ø> (ø)`
couch	`94.76% <ø> (ø)`
couchbase	`85.23% <ø> (ø)`
crio	`89.79% <ø> (ø)`
datadog_checks_base	`89.54% <ø> (+0.28%)`	⬆️
datadog_checks_dev	`77.61% <ø> (-0.03%)`	⬇️
datadog_checks_downloader	`81.37% <ø> (+3.22%)`	⬆️
datadog_cluster_agent	`90.19% <ø> (ø)`
dcgm	`93.54% <ø> (ø)`
ddev	`87.99% <100.00%> (-0.03%)`	⬇️
directory	`97.11% <ø> (+0.22%)`	⬆️
disk	`87.72% <ø> (ø)`
dns_check	`93.84% <ø> (ø)`
dotnetclr	`84.05% <ø> (ø)`
druid	`97.70% <ø> (ø)`
duckdb	`84.53% <ø> (ø)`
ecs_fargate	`83.71% <ø> (ø)`
eks_fargate	`94.05% <ø> (ø)`
elastic	`93.92% <ø> (ø)`
envoy	`95.41% <ø> (+5.46%)`	⬆️
esxi	`93.98% <ø> (ø)`
etcd	`95.56% <ø> (ø)`
exchange_server	`93.06% <ø> (ø)`
external_dns	`89.28% <ø> (ø)`
fluentd	`84.21% <ø> (ø)`
fluxcd	`88.31% <ø> (ø)`
fly_io	`97.13% <ø> (ø)`
foundationdb	`82.77% <ø> (ø)`
gearmand	`77.84% <ø> (ø)`
gitlab	`92.27% <ø> (ø)`
gitlab_runner	`92.76% <ø> (ø)`
glusterfs	`80.00% <ø> (ø)`
go_expvar	`92.66% <ø> (ø)`
gunicorn	`93.28% <ø> (ø)`
haproxy	`95.35% <ø> (ø)`
harbor	`89.08% <ø> (-0.58%)`	⬇️
hazelcast	`92.30% <ø> (ø)`
hdfs_datanode	`89.63% <ø> (ø)`
hdfs_namenode	`86.60% <ø> (ø)`
hive	`51.42% <ø> (ø)`
hivemq	`61.90% <ø> (ø)`
http_check	`94.26% <ø> (ø)`
hudi	`73.91% <ø> (ø)`
ibm_ace	`92.25% <ø> (ø)`
ibm_db2	`86.29% <ø> (ø)`
ibm_i	`82.36% <ø> (ø)`
ibm_mq	`91.46% <ø> (+0.13%)`	⬆️
ibm_was	`96.06% <ø> (ø)`
ignite	`46.66% <ø> (ø)`
iis	`95.02% <ø> (ø)`
impala	`97.97% <ø> (ø)`
infiniband	`92.34% <ø> (ø)`
istio	`77.86% <ø> (ø)`
jboss_wildfly	`47.36% <ø> (ø)`
kafka	`64.70% <ø> (ø)`
kafka_consumer	`92.55% <ø> (+1.51%)`	⬆️
karpenter	`95.06% <ø> (ø)`
keda	`88.05% <ø> (ø)`
kong	`88.42% <ø> (ø)`
kube_apiserver_metrics	`97.75% <ø> (ø)`
kube_controller_manager	`97.88% <ø> (ø)`
kube_dns	`95.94% <ø> (ø)`
kube_metrics_server	`94.87% <ø> (ø)`
kube_proxy	`96.80% <ø> (ø)`
kube_scheduler	`97.92% <ø> (ø)`
kubeflow	`93.22% <ø> (ø)`
kubelet	`91.09% <ø> (ø)`
kubernetes_cluster_autoscaler	`93.22% <ø> (ø)`
kubernetes_state	`89.49% <ø> (ø)`
kubevirt_api	`82.75% <ø> (ø)`
kubevirt_controller	`85.36% <ø> (ø)`
kubevirt_handler	`91.32% <ø> (ø)`
kuma	`79.03% <ø> (?)`
kyototycoon	`85.96% <ø> (ø)`
kyverno	`82.27% <ø> (ø)`
lighttpd	`83.64% <ø> (ø)`
linkerd	`84.70% <ø> (ø)`
linux_proc_extras	`96.20% <ø> (ø)`
mapr	`82.70% <ø> (ø)`
mapreduce	`81.99% <ø> (ø)`
marathon	`83.06% <ø> (ø)`
marklogic	`96.08% <ø> (+2.37%)`	⬆️
mcache	`93.99% <ø> (ø)`
mesos_master	`89.71% <ø> (ø)`
milvus	`92.30% <ø> (ø)`
mongo	`93.12% <ø> (+0.22%)`	⬆️
mysql	`89.30% <ø> (+0.15%)`	⬆️
nagios	`89.01% <ø> (ø)`
network	`93.89% <ø> (ø)`
nfsstat	`94.67% <ø> (-0.54%)`	⬇️
nginx	`94.65% <ø> (ø)`
nginx_ingress_controller	`98.55% <ø> (ø)`
nvidia_nim	`93.10% <ø> (ø)`
nvidia_triton	`88.52% <ø> (ø)`
octopus_deploy	`99.25% <ø> (ø)`
openldap	`96.33% <ø> (ø)`
openmetrics	`98.05% <ø> (ø)`
openstack	`55.11% <ø> (ø)`
openstack_controller	`94.65% <ø> (ø)`
pdh_check	`95.65% <ø> (ø)`
pgbouncer	`94.91% <ø> (ø)`
php_fpm	`90.45% <ø> (ø)`
postfix	`88.04% <ø> (ø)`
postgres	`93.09% <ø> (+3.44%)`	⬆️
powerdns_recursor	`96.65% <ø> (ø)`
presto	`59.09% <ø> (ø)`
process	`85.99% <ø> (ø)`
prometheus	`94.17% <ø> (ø)`
proxysql	`98.97% <ø> (ø)`
pulsar	`100.00% <ø> (ø)`
quarkus	`100.00% <ø> (ø)`
rabbitmq	`95.67% <ø> (ø)`
ray	`96.45% <ø> (ø)`
redisdb	`89.72% <ø> (ø)`
rethinkdb	`98.27% <ø> (ø)`
riak	`99.21% <ø> (ø)`
riakcs	`88.82% <ø> (ø)`
sap_hana	`90.54% <ø> (ø)`
scylla	`98.82% <ø> (ø)`
silk	`93.91% <ø> (ø)`
silverstripe_cms	`76.00% <ø> (ø)`
singlestore	`91.70% <ø> (ø)`
slurm	`90.86% <ø> (+1.53%)`	⬆️
snmp	`95.71% <ø> (ø)`
snowflake	`96.27% <ø> (ø)`
solr	`56.25% <ø> (ø)`
sonarqube	`98.10% <ø> (ø)`
sonatype_nexus	`76.69% <ø> (ø)`
spark	`93.50% <ø> (+0.30%)`	⬆️
sqlserver	`90.43% <ø> (+3.65%)`	⬆️
squid	`100.00% <ø> (ø)`
ssh_check	`91.32% <ø> (ø)`
statsd	`87.36% <ø> (ø)`
strimzi	`89.78% <ø> (ø)`
supabase	`93.97% <ø> (ø)`
supervisord	`90.14% <ø> (ø)`
system_core	`92.52% <ø> (ø)`
system_swap	`98.30% <ø> (ø)`
tcp_check	`92.05% <ø> (ø)`
teamcity	`87.39% <ø> (ø)`
tekton	`82.45% <ø> (ø)`
teleport	`98.16% <ø> (ø)`
temporal	`100.00% <ø> (ø)`
teradata	`94.27% <ø> (ø)`
tibco_ems	`91.98% <ø> (ø)`
tls	`90.26% <ø> (ø)`
tomcat	`60.41% <ø> (ø)`
torchserve	`97.32% <ø> (ø)`
traefik_mesh	`76.75% <ø> (ø)`
traffic_server	`96.13% <ø> (ø)`
twemproxy	`79.45% <ø> (ø)`
twistlock	`80.41% <ø> (ø)`
varnish	`84.22% <ø> (ø)`
vault	`95.67% <ø> (ø)`
velero	`85.00% <ø> (ø)`
vertica	`98.34% <ø> (ø)`
vllm	`94.44% <ø> (ø)`
voltdb	`96.84% <ø> (ø)`
vsphere	`96.62% <ø> (ø)`
weaviate	`76.27% <ø> (ø)`
weblogic	`70.83% <ø> (ø)`
win32_event_log	`86.54% <ø> (ø)`
windows_performance_counters	`98.36% <ø> (ø)`
windows_service	`94.53% <ø> (ø)`
wmi_check	`92.91% <ø> (ø)`
yarn	`89.93% <ø> (ø)`
zk	`82.30% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iliakur · 2025-06-02T14:13:58Z

@alyssamui2 should we remove the ddev validation and replace it with APW ones? maintaining both at the same time sounds like a time sink.

alyssamui2 · 2025-06-02T20:17:25Z

@alyssamui2 should we remove the ddev validation and replace it with APW ones? maintaining both at the same time sounds like a time sink.

I've been told that the plan is that the ddev validators will eventually be removed so we can consolidate into 1 validator in the future.

Review from steveny91 is dismissed. Related teams and files:

agent-integrations
- zk/metadata.csv

Review from Kyle-Neale is dismissed. Related teams and files:

agent-integrations
- zk/metadata.csv

This reverts commit 49d4d04.

dd-devflow · 2025-06-09T14:44:33Z

View all feedbacks in Devflow UI.

2025-06-09 14:44:31 UTC ℹ️ Start processing command /to-staging
If you need support, contact us on Slack #devflow!

2025-06-09 14:44:31 UTC ❌ Devflow: /to-staging

This command is disabled.

If you need support, contact us on Slack #devflow with those details!

alyssamui2 · 2025-06-12T14:01:17Z

/merge

dd-devflow · 2025-06-12T14:01:21Z

View all feedbacks in Devflow UI.

2025-06-12 14:01:21 UTC ℹ️ Start processing command /merge

2025-06-12 14:01:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-12 18:02:13 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

alyssamui2 · 2025-06-13T15:19:53Z

/merge

dd-devflow · 2025-06-13T15:19:58Z

View all feedbacks in Devflow UI.

2025-06-13 15:19:58 UTC ℹ️ Start processing command /merge

2025-06-13 15:20:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-13 19:21:16 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Kyle-Neale · 2025-06-13T15:24:24Z

/merge

integrations-core doesn't use devflow merge queue but GH merge queue instead.

alyssamui2 · 2025-06-13T15:25:00Z

/merge

integrations-core doesn't use devflow merge queue but GH merge queue instead.

Ah I didn't know 😅 Thanks for adding it for me!

only error if required headers are missing

7835112

alyssamui2 requested a review from a team as a code owner May 30, 2025 18:00

temporal-github-worker-2 bot added agent/review-requested ecosystems/review-requested product/review-requested labels May 30, 2025

datadog-agent-integrations-bot bot added ddev team/agent-integrations labels May 30, 2025

alyssamui2 added 2 commits May 30, 2025 14:15

update changelog

2586078

fix test

777a58e

fix test

777a58e

alyssamui2 self-assigned this May 30, 2025

steveny91 previously approved these changes Jun 3, 2025

View reviewed changes

temporal-github-worker-1 bot added agent/approved and removed agent/review-requested labels Jun 3, 2025

Kyle-Neale previously approved these changes Jun 3, 2025

View reviewed changes

test remove interval

49d4d04

alyssamui2 requested a review from a team as a code owner June 9, 2025 14:41

temporal-github-worker-1 bot added agent/review-requested and removed agent/approved labels Jun 9, 2025

datadog-agent-integrations-bot bot added integration/zk team/documentation labels Jun 9, 2025

Revert "test remove interval"

d25ecde

This reverts commit 49d4d04.

cswatt approved these changes Jun 9, 2025

View reviewed changes

temporal-github-worker-1 bot added the docs/approved label Jun 9, 2025

do not require curated_metric

e118bf5

dd-devflow bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: waiting labels Jun 12, 2025

steveny91 approved these changes Jun 13, 2025

View reviewed changes

temporal-github-worker-1 bot added agent/approved and removed agent/review-requested labels Jun 13, 2025

dd-devflow bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Jun 13, 2025

Kyle-Neale approved these changes Jun 13, 2025

View reviewed changes

Kyle-Neale added this pull request to the merge queue Jun 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 13, 2025

steveny91 added this pull request to the merge queue Jun 13, 2025

dd-devflow bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Jun 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 13, 2025

Kyle-Neale added this pull request to the merge queue Jun 13, 2025

Merged via the queue into master with commit fd9914d Jun 13, 2025
456 of 466 checks passed

Kyle-Neale deleted the alyssamui2/update-required-metadata-headers branch June 13, 2025 20:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MINPROC-2201] Update ddev metadata validator to only error on required headers #20419

[MINPROC-2201] Update ddev metadata validator to only error on required headers #20419

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alyssamui2 commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[MINPROC-2201] Update ddev metadata validator to only error on required headers #20419

[MINPROC-2201] Update ddev metadata validator to only error on required headers #20419

Uh oh!

Conversation

Uh oh!

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alyssamui2 commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!