Use team-reviewers in golang.org/x update workflow #38074

pgimalac · 2025-06-19T13:12:30Z

What does this PR do?

Fix the golang.org/x/... update workflow to properly request review from agent-runtimes team.

Motivation

Get notified when the PR is created.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

pgimalac · 2025-06-19T13:48:26Z

Tested with #38077

cit-pr-commenter · 2025-06-19T14:00:32Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6f2201c5-775f-4977-8fe4-9311a9555e8d

Baseline: 808f367
Comparison: 4d40467
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+1.79	[+1.65, +1.93]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.62	[+0.56, +0.68]	1	Logs
➖	file_tree	memory utilization	+0.54	[+0.39, +0.70]	1	Logs
➖	quality_gate_idle	memory utilization	+0.47	[+0.41, +0.53]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.39	[+0.30, +0.47]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.15	[-0.70, +1.00]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.09	[-0.50, +0.67]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.55, +0.65]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.50, +0.57]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.58, +0.62]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.01	[-0.23, +0.25]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.03]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.29, +0.28]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.62, +0.57]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.08	[-0.66, +0.51]	1	Logs
➖	ddot_logs	memory utilization	-0.08	[-0.18, +0.01]	1	Logs
➖	ddot_metrics	memory utilization	-0.15	[-0.27, -0.03]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.16	[-0.77, +0.45]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.53	[-0.70, -0.37]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.76	[-0.89, -0.64]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.85	[-0.90, -0.81]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.68	[-5.38, +0.02]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-3.56	[-6.54, -0.58]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-19T15:00:25Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 808f367

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${697.05}$$ < $${697.37}$$	$${-0.03}$$	$${176.09}$$ < $${177.03}$$
✅	agent_deb_amd64_fips	$${0}$$	$${695.35}$$ < $${695.59}$$	$${+0.02}$$	$${175.56}$$ < $${176.51}$$
✅	agent_heroku_amd64	$${0}$$	$${358.68}$$ < $${359.67}$$	$${-0}$$	$${96.53}$$ < $${97.47}$$
✅	agent_msi	$${0}$$	$${958.87}$$ < $${959.86}$$	$${+0.02}$$	$${146.32}$$ < $${147.27}$$
✅	agent_rpm_amd64	$${0}$$	$${697.04}$$ < $${697.36}$$	$${+0.03}$$	$${177.72}$$ < $${178.56}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${695.34}$$ < $${695.58}$$	$${+0.01}$$	$${177.56}$$ < $${178.43}$$
✅	agent_rpm_arm64	$${0}$$	$${687.06}$$ < $${687.37}$$	$${+0}$$	$${161.12}$$ < $${161.99}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${685.47}$$ < $${685.72}$$	$${-0.01}$$	$${160.28}$$ < $${161.11}$$
✅	agent_suse_amd64	$${0}$$	$${697.04}$$ < $${697.36}$$	$${+0.03}$$	$${177.72}$$ < $${178.56}$$
✅	agent_suse_amd64_fips	$${0}$$	$${695.34}$$ < $${695.58}$$	$${+0.01}$$	$${177.56}$$ < $${178.43}$$
✅	agent_suse_arm64	$${0}$$	$${687.06}$$ < $${687.37}$$	$${+0}$$	$${161.12}$$ < $${161.99}$$
✅	agent_suse_arm64_fips	$${0}$$	$${685.47}$$ < $${685.72}$$	$${-0.01}$$	$${160.28}$$ < $${161.11}$$
✅	docker_agent_amd64	$${0}$$	$${780.85}$$ < $${781.16}$$	$${+0}$$	$${268.82}$$ < $${269.63}$$
✅	docker_agent_arm64	$${-0}$$	$${794.32}$$ < $${794.62}$$	$${+0}$$	$${256.16}$$ < $${257.0}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${972.04}$$ < $${972.35}$$	$${+0}$$	$${337.77}$$ < $${338.6}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${974.11}$$ < $${974.41}$$	$${+0}$$	$${321.1}$$ < $${321.97}$$
✅	docker_agent_windows1809	$${-0.54}$$	$${1179.98}$$ < $${1488.0}$$	$${-0.35}$$	$${415.86}$$ < $${488.95}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${5910.48}$$ < $${6218.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_core_jmx	$${-0.2}$$	$${6032.05}$$ < $${6361.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_jmx	$${-0}$$	$${1302.15}$$ < $${1609.5}$$	$${+0.01}$$	$${458.48}$$ < $${531.32}$$
✅	docker_agent_windows2022	$${+0.14}$$	$${1199.83}$$ < $${1507.0}$$	$${-0.01}$$	$${428.9}$$ < $${501.7}$$
✅	docker_agent_windows2022_core	$${-0.17}$$	$${5883.58}$$ < $${6311.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_core_jmx	$${-0.47}$$	$${6004.99}$$ < $${6313.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_jmx	$${-0.16}$$	$${1321.44}$$ < $${1628.16}$$	$${-0.03}$$	$${471.19}$$ < $${543.98}$$
✅	docker_cluster_agent_amd64	$${0}$$	$${212.85}$$ < $${213.79}$$	$${+0}$$	$${72.39}$$ < $${73.33}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${228.76}$$ < $${229.64}$$	$${-0}$$	$${68.68}$$ < $${69.6}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
8000 ✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${39.22}$$ < $${39.57}$$	$${+0}$$	$${15.12}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.88}$$ < $${38.2}$$	$${-0}$$	$${14.53}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.0}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.02}$$ < $${29.97}$$	$${-0}$$	$${6.94}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.44}$$ < $${51.38}$$	$${+0}$$	$${12.85}$$ < $${13.79}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.91}$$ < $${48.85}$$	$${-0}$$	$${11.14}$$ < $${12.09}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.48}$$ < $${48.42}$$	$${-0}$$	$${11.2}$$ < $${12.16}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.44}$$ < $${51.38}$$	$${+0}$$	$${12.87}$$ < $${13.81}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.91}$$ < $${48.85}$$	$${+0}$$	$${11.16}$$ < $${12.11}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.44}$$ < $${51.38}$$	$${+0}$$	$${12.87}$$ < $${13.81}$$

pgimalac · 2025-06-20T09:23:00Z

/merge

dd-devflow · 2025-06-20T09:23:04Z

View all feedbacks in Devflow UI.

2025-06-20 09:23:03 UTC ℹ️ Start processing command /merge

2025-06-20 09:23:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-20 10:06:13 UTC ℹ️ MergeQueue: This merge request was merged

fix: use team-reviewers to request review from team

4d40467

pgimalac added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-runtimes labels Jun 19, 2025

pgimalac had a problem deploying to main June 19, 2025 13:13 — with GitHub Actions Failure

github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 19, 2025

pgimalac had a problem deploying to main June 19, 2025 13:25 — with GitHub Actions Failure

pgimalac temporarily deployed to main June 19, 2025 13:27 — with GitHub Actions Inactive

pgimalac marked this pull request as ready for review June 19, 2025 13:48

pgimalac requested a review from a team as a code owner June 19, 2025 13:48

pgimalac requested a review from GustavoCaso June 19, 2025 13:48

pgimalac added the ask-review Ask required teams to review this PR label Jun 19, 2025

louis-cqrl approved these changes Jun 19, 2025

View reviewed changes

dd-mergequeue bot merged commit 87ce824 into main Jun 20, 2025
265 of 267 checks passed

dd-mergequeue bot deleted the pgimalac/golang-org-x-update-workflow-fix-reviewer-team branch June 20, 2025 10:06

github-actions bot added this to the 7.69.0 milestone Jun 20, 2025

github-actions bot pushed a commit that referenced this pull request Jun 20, 2025

Use team-reviewers in golang.org/x update workflow (#38074) 87ce824

497e753

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use team-reviewers in golang.org/x update workflow #38074

Use team-reviewers in golang.org/x update workflow #38074

Uh oh!

Uh oh!

Uh oh!

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Use team-reviewers in golang.org/x update workflow #38074

Use team-reviewers in golang.org/x update workflow #38074

Uh oh!

Conversation

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!