chore(fleet): Skip daemon Start if remote_updates is false #38066

BaptisteFoy · 2025-06-19T09:13:20Z

What does this PR do?

We're seeing a lot of failures for get_states when running DJM install scripts. This happens because while the installer setup is running the DB is locked; but the daemon still tries to call get_states; causing it to fail because of the lock. The core issue is that we call get_states while we're still in the installation phase.

This PR only alleviates it by making sure the daemon doesn't start calling get_states when it should in fact be disabled: there can be a first call between the installer process startup & the moment it is deactivated because remote_updates is disabled. Thus this PR makes sure the daemon component doesn't even start if remote_updates: false

Motivation

Less errors in telemetry

Describe how you validated your changes

E2E

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-06-19T10:06:28Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 48b51538-a036-4500-8028-0b59a56b3567

Baseline: 6e1d012
Comparison: 2163ba3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.23	[-1.79, +4.24]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.99	[+0.15, +1.83]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.45	[+0.40, +0.51]	1	Logs
➖	quality_gate_idle	memory utilization	+0.23	[+0.15, +0.30]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.22	[+0.10, +0.35]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.15	[-0.42, +0.73]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.07	[-0.54, +0.67]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.05	[-0.55, +0.65]	1	Logs
➖	docker_containers_memory	memory utilization	+0.05	[-0.02, +0.12]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.55, +0.63]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.27, +0.29]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.01	[-0.23, +0.25]	1	Logs
➖	ddot_metrics	memory utilization	+0.01	[-0.11, +0.12]	1	Logs
➖	ddot_logs	memory utilization	+0.00	[-0.09, +0.10]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.56, +0.57]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.00	[-0.09, +0.08]	1	Logs bounds checks dashboard
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.63, +0.60]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.09	[-0.67, +0.49]	1	Logs
➖	file_tree	memory utilization	-0.21	[-0.36, -0.06]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.48	[-0.53, -0.43]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.78	[-3.53, +1.98]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.82	[-0.99, -0.66]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-19T11:03:07Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6e1d012

Successful checks

Info

8000

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${697.05}$$ < $${697.37}$$	$${-0.02}$$	$${176.11}$$ < $${177.03}$$
✅	agent_deb_amd64_fips	$${0}$$	$${695.36}$$ < $${695.59}$$	$${+0.03}$$	$${175.56}$$ < $${176.51}$$
✅	agent_heroku_amd64	$${0}$$	$${358.69}$$ < $${359.67}$$	$${-0}$$	$${96.52}$$ < $${97.47}$$
✅	agent_msi	$${0}$$	$${958.89}$$ < $${959.86}$$	$${+0.01}$$	$${146.31}$$ < $${147.27}$$
✅	agent_rpm_amd64	$${0}$$	$${697.04}$$ < $${697.36}$$	$${-0.04}$$	$${177.67}$$ < $${178.56}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${695.35}$$ < $${695.58}$$	$${-0.03}$$	$${177.57}$$ < $${178.43}$$
✅	agent_rpm_arm64	$${0}$$	$${687.07}$$ < $${687.37}$$	$${-0}$$	$${161.11}$$ < $${161.99}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${685.48}$$ < $${685.72}$$	$${+0.06}$$	$${160.3}$$ < $${161.11}$$
✅	agent_suse_amd64	$${0}$$	$${697.04}$$ < $${697.36}$$	$${-0.04}$$	$${177.67}$$ < $${178.56}$$
✅	agent_suse_amd64_fips	$${0}$$	$${695.35}$$ < $${695.58}$$	$${-0.03}$$	$${177.57}$$ < $${178.43}$$
✅	agent_suse_arm64	$${0}$$	$${687.07}$$ < $${687.37}$$	$${-0}$$	$${161.11}$$ < $${161.99}$$
✅	agent_suse_arm64_fips	$${0}$$	$${685.48}$$ < $${685.72}$$	$${+0.06}$$	$${160.3}$$ < $${161.11}$$
✅	docker_agent_amd64	$${0}$$	$${780.85}$$ < $${781.16}$$	$${+0}$$	$${268.81}$$ < $${269.63}$$
✅	docker_agent_arm64	$${+0}$$	$${794.32}$$ < $${794.62}$$	$${+0}$$	$${256.17}$$ < $${257.0}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${972.05}$$ < $${972.35}$$	$${-0}$$	$${337.78}$$ < $${338.6}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${974.12}$$ < $${974.41}$$	$${-0.01}$$	$${321.11}$$ < $${321.97}$$
✅	docker_agent_windows1809	$${+0.02}$$	$${1180.56}$$ < $${1488.0}$$	$${+0.13}$$	$${416.35}$$ < $${488.95}$$
✅	docker_agent_windows1809_core	$${-0.01}$$	$${5910.5}$$ < $${6218.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_core_jmx	$${+0}$$	$${6032.07}$$ < $${6361.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_jmx	$${-0.07}$$	$${1302.1}$$ < $${1609.5}$$	$${-0.06}$$	$${458.48}$$ < $${531.32}$$
✅	docker_agent_windows2022	$${+0.16}$$	$${1200.0}$$ < $${1507.0}$$	$${-0.02}$$	$${428.91}$$ < $${501.7}$$
✅	docker_agent_windows2022_core	$${-0.24}$$	$${5883.32}$$ < $${6311.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_core_jmx	$${-0.27}$$	$${6005.2}$$ < $${6313.0}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_jmx	$${-0}$$	$${1321.23}$$ < $${1628.16}$$	$${-0}$$	$${471.2}$$ < $${543.98}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${212.86}$$ < $${213.79}$$	$${+0}$$	$${72.39}$$ < $${73.33}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${228.76}$$ < $${229.64}$$	$${-0}$$	$${68.67}$$ < $${69.6}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${39.22}$$ < $${39.57}$$	$${-0}$$	$${15.12}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.88}$$ < $${38.2}$$	$${+0}$$	$${14.53}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.0}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.02}$$ < $${29.97}$$	$${+0}$$	$${6.94}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.44}$$ < $${51.38}$$	$${+0}$$	$${12.85}$$ < $${13.79}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.91}$$ < $${48.85}$$	$${+0}$$	$${11.14}$$ < $${12.09}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.49}$$ < $${48.42}$$	$${+0}$$	$${11.21}$$ < $${12.16}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.44}$$ < $${51.38}$$	$${-0}$$	$${12.86}$$ < $${13.81}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.91}$$ < $${48.85}$$	$${+0}$$	$${11.17}$$ < $${12.11}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.44}$$ < $${51.38}$$	$${-0}$$	$${12.86}$$ < $${13.81}$$

BaptisteFoy · 2025-06-19T11:41:59Z

/merge

dd-devflow · 2025-06-19T11:42:03Z

View all feedbacks in Devflow UI.

2025-06-19 11:42:03 UTC ℹ️ Start processing command /merge

2025-06-19 11:42:07 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-19 12:23:02 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added short review PR is simple enough to be reviewed quickly team/windows-agent labels Jun 19, 2025

chore(fleet): Skip daemon Start if remote_updates is false

2163ba3

BaptisteFoy added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation and removed team/windows-agent labels Jun 19, 2025

BaptisteFoy force-pushed the baptiste.foy/FA/skip-daemon-init branch from edde882 to 2163ba3 Compare June 19, 2025 09:16

BaptisteFoy marked this pull request as ready for review June 19, 2025 11:39

BaptisteFoy requested review from a team as code owners June 19, 2025 11:39

coignetp approved these changes Jun 19, 2025

View reviewed changes

dd-mergequeue bot merged commit d8f8178 into main Jun 19, 2025
287 checks passed

dd-mergequeue bot deleted the baptiste.foy/FA/skip-daemon-init branch June 19, 2025 12:23

github-actions bot added this to the 7.69.0 milestone Jun 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(fleet): Skip daemon Start if remote_updates is false #38066

chore(fleet): Skip daemon Start if remote_updates is false #38066

Uh oh!

Uh oh!

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore(fleet): Skip daemon Start if remote_updates is false #38066

chore(fleet): Skip daemon Start if remote_updates is false #38066

Uh oh!

Conversation

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!