8000 [AGENTRUN-485] enable mTLS for core Agent IPC API by misteriaud · Pull Request #37966 · DataDog/datadog-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[AGENTRUN-485] enable mTLS for core Agent IPC API #37966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2025
Merged

[AGENTRUN-485] enable mTLS for core Agent IPC API #37966

merged 6 commits into from
Jun 19, 2025

Conversation

misteriaud
Copy link
Contributor
@misteriaud misteriaud commented Jun 16, 2025 •
edited
Loading

What does this PR do?

This PR enable mutualTLS on the CoreAgent IPC server.

Motivation

Enabling mTLS increase the security level of the IPC server.

Describe how you validated your changes

Added a unit-test.

@misteriaud misteriaud requested a review from a team as a code owner June 16, 2025 13:36
@misteriaud misteriaud requested a review from GustavoCaso June 16, 2025 13:36
@github-actions github-actions bot added team/agent-runtimes short review PR is simple enough to be reviewed quickly labels Jun 16, 2025
louis-cqrl
louis-cqrl approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor
@louis-cqrl louis-cqrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment lgtm otherwise

GustavoCaso
GustavoCaso reviewed Jun 16, 2025
View reviewed changes
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 16, 2025
@GustavoCaso
Copy link
Member

@misteriaud Awesome work. Could enabling mTLS for IPC now affect the soon-to-start work on adding the remote agent registry into the IPC server?

@misteriaud
Copy link
Contributor Author

@GustavoCaso the RemoteAgentRegistry migration will benefit of this higher security level on IPC API for sure.

@agent-platform-auto-pr
Copy link
Contributor
agent-platform-auto-pr bot commented Jun 16, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor bf87d3a

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${697.08}$$ < $${697.37}$$ $${-0.01}$$ $${176.12}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${0}$$ $${695.38}$$ < $${695.59}$$ $${+0}$$ $${175.57}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${-0}$$ $${358.71}$$ < $${359.67}$$ $${-0}$$ $${96.53}$$ < $${97.47}$$
✅ agent_msi $${+0}$$ $${958.98}$$ < $${959.86}$$ $${+0}$$ $${146.32}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${0}$$ $${697.07}$$ < $${697.36}$$ $${-0}$$ $${177.69}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${0}$$ $${695.37}$$ < $${695.58}$$ $${+0.01}$$ $${177.59}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${0}$$ $${687.09}$$ < $${687.37}$$ $${-0.02}$$ $${161.14}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${0}$$ $${685.49}$$ < $${685.72}$$ $${-0.02}$$ $${160.26}$$ < $${161.11}$$
✅ agent_suse_amd64 $${0}$$ $${697.07}$$ < $${697.36}$$ $${-0}$$ $${177.69}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${0}$$ $${695.37}$$ < $${695.58}$$ $${+0.01}$$ $${177.59}$$ < $${178.43}$$
✅ agent_suse_arm64 $${0}$$ $${687.09}$$ < $${687.37}$$ $${-0.02}$$ $${161.14}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${0}$$ $${685.49}$$ < $${685.72}$$ $${-0.02}$$ $${160.26}$$ < $${161.11}$$
✅ docker_agent_amd64 $${0}$$ $${780.88}$$ < $${781.16}$$ $${+0}$$ $${268.81}$$ < $${269.63}$$
✅ docker_agent_arm64 $${0}$$ $${794.34}$$ < $${794.62}$$ $${+0}$$ $${256.18}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${972.07}$$ < $${972.35}$$ $${+0}$$ $${337.78}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${974.14}$$ < $${974.41}$$ $${+0.01}$$ $${321.13}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${+0}$$ $${1180.55}$$ < $${1488.0}$$ $${+0.02}$$ $${416.22}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${-0}$$ $${5910.51}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-22.32}$$ $${6032.08}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1302.18}$$ < $${1609.5}$$ $${-0.05}$$ $${458.45}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${-0.25}$$ $${1199.76}$$ < $${1507.0}$$ $${+0.06}$$ $${428.97}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${-0.28}$$ $${5883.57}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${-0.26}$$ $${6005.17}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${-0.36}$$ $${1321.24}$$ < $${1628.16}$$ $${+0.01}$$ $${471.21}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${212.88}$$ < $${213.79}$$ $${+0}$$ $${72.39}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${228.76}$$ < $${229.64}$$ $${+0}$$ $${68.67}$$ < $${69.6}$$
✅ d 8000 ocker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${-0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.47}$$ < $${51.38}$$ $${+0}$$ $${12.85}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.94}$$ < $${48.85}$$ $${+0}$$ $${11.15}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${48.42}$$ $${-0}$$ $${11.21}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.47}$$ < $${51.38}$$ $${+0}$$ $${12.87}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${48.85}$$ $${+0}$$ $${11.17}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.47}$$ < $${51.38}$$ $${+0}$$ $${12.87}$$ < $${13.81}$$

@misteriaud misteriaud added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jun 19, 2025
@misteriaud
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented Jun 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-19 14:29:48 UTC ℹ️ Start processing command /merge

2025-06-19 14:29:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-19 18:08:04 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-19 18:59:53 UTC ℹ️ MergeQueue: This merge request was merged

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: beff96ce-8330-406a-8857-c65dbb558b89

Baseline: bf87d3a
Comparison: 4d2d218
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ otlp_ingest_metrics memory utilization +0.47 [+0.30, +0.65] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.45 [+0.41, +0.50] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.25 [+0.14, +0.35] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.20, +0.28] 1 Logs
➖ file_tree memory utilization +0.02 [-0.12, +0.16] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.01 [-0.58, +0.61] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.58, +0.59] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.00 [-0.53, +0.53] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.27, +0.26] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.67, +0.66] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.01 [-0.08, +0.06] 1 Logs
➖ ddot_metrics memory utilization -0.01 [-0.13, +0.11] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.65, +0.54] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.08 [-0.69, +0.53] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.12 [-0.69, +0.45] 1 Logs
➖ ddot_logs memory utilization -0.17 [-0.27, -0.08] 1 Logs
➖ quality_gate_idle memory utilization -0.26 [-0.32, -0.20] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.28 [-0.34, -0.22] 1 Logs
➖ docker_containers_cpu % cpu utilization -0.36 [-3.42, +2.71] 1 Logs
➖ otlp_ingest_logs memory utilization -0.56 [-0.69, -0.43] 1 Logs
➖ quality_gate_logs % cpu utilization -1.53 [-4.23, +1.17] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -1.55 [-2.42, -0.68] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit a9e95a7 into main Jun 19, 2025
234 checks passed
@dd-mergequeue dd-mergequeue bot deleted the AGENTRUN-485-enable-m-tls-on-ipc-api branch June 19, 2025 18:59
@github-actions github-actions bot added this to the 7.69.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-cqrl louis-cqrl louis-cqrl approved these changes

@GustavoCaso GustavoCaso GustavoCaso approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-runtimes
Projects
None yet
Milestone
7.69.0
Development

Successfully merging this pull request may close these issues.
3 participants
@misteriaud @GustavoCaso @louis-cqrl
0