8000 update snapshots by astuyve · Pull Request #37947 · DataDog/datadog-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update snapshots #37947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

update snapshots #37947

merged 2 commits into from
Jun 16, 2025

Conversation

astuyve
Copy link
Contributor
@astuyve astuyve commented Jun 13, 2025

What does this PR do?

Fixes metrics tests

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@astuyve astuyve requested review from a team as code owners June 13, 2025 18:06
@astuyve astuyve added this to the Triage milestone Jun 13, 2025
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jun 13, 2025
@astuyve astuyve added the qa/no-code-change No code change in Agent code requiring validation label Jun 13, 2025
@cit-pr-commenter cit-pr-commenter
Copy link
cit-pr-commenter bot commented Jun 13, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: aa6845ec-ecd0-41b0-a2a8-f616fc59a8ff

Baseline: 3089361
Comparison: cde082f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

8000
perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.47 [-0.56, +5.51] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +1.00 [+0.95, +1.06] 1 Logs
➖ ddot_logs memory utilization +0.54 [+0.43, +0.66] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.13 [-0.44, +0.69] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.12 [-0.44, +0.68] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.05 [-0.54, +0.63] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.54, +0.62] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.03 [-0.55, +0.60] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.22, +0.25] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.01 [-0.08, +0.09] 1 Logs bounds checks dashboard
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.26] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.62, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.63, +0.54] 1 Logs
➖ otlp_ingest_logs memory utilization -0.08 [-0.20, +0.05] 1 Logs
➖ file_tree memory utilization -0.11 [-0.25, +0.02] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.14 [-0.30, +0.03] 1 Logs
➖ ddot_metrics memory utilization -0.25 [-0.37, -0.13] 1 Logs
➖ quality_gate_logs % cpu utilization -0.29 [-3.05, +2.47] 1 Logs bounds checks dashboard
➖docker_containers_memory memory utilization -0.61 [-0.68, -0.53] 1 Logs
➖ quality_gate_idle memory utilization -0.95 [-1.00, -0.89] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -1.60 [-2.44, -0.77] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.99 [-2.05, -1.93] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor
agent-platform-auto-pr bot commented Jun 13, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3089361

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0}$$ $${696.38}$$ < $${697.37}$$ $${+26.73}$$ $${176.04}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.67}$$ < $${695.59}$$ $${+25.57}$$ $${175.54}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${+11.31}$$ $${96.51}$$ < $${97.47}$$
✅ agent_msi $${0}$$ $${958.88}$$ < $${959.86}$$ $${+0.02}$$ $${146.3}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${+0}$$ $${696.37}$$ < $${697.36}$$ $${+25.84}$$ $${177.56}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.66}$$ < $${695.58}$$ $${+24.97}$$ $${177.47}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${0}$$ $${686.38}$$ < $${687.37}$$ $${+22.79}$$ $${161.07}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.79}$$ < $${685.72}$$ $${+21.48}$$ $${160.2}$$ < $${161.11}$$
✅ agent_suse_amd64 $${+0}$$ $${696.37}$$ < $${697.36}$$ $${+25.84}$$ $${177.56}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.66}$$ < $${695.58}$$ $${+24.97}$$ $${177.47}$$ < $${178.43}$$
✅ agent_suse_arm64 $${0}$$ $${686.38}$$ < $${687.37}$$ $${+22.79}$$ $${161.07}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.79}$$ < $${685.72}$$ $${+21.48}$$ $${160.2}$$ < $${161.11}$$
✅ docker_agent_amd64 $${-0}$$ $${780.17}$$ < $${781.16}$$ $${-0}$$ $${268.68}$$ < $${269.63}$$
✅ docker_agent_arm64 $${-0}$$ $${793.63}$$ < $${794.62}$$ $${-0}$$ $${256.05}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${971.36}$$ < $${972.35}$$ $${-0}$$ $${337.64}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${973.43}$$ < $${974.41}$$ $${+0}$$ $${320.99}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${+0}$$ $${1487.02}$$ < $${1488.0}$$ $${+0.02}$$ $${488.04}$$ < $${488.95}$$
✅ docker_agent_windows1809_core DataNotFound $${6214.76}$$ < $${6218.0}$$ DataNotFound $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${6338.55}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.65}$$ < $${1609.5}$$ $${-0.02}$$ $${530.27}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${-0.01}$$ $${1506.31}$$ < $${1507.0}$$ $${-0.01}$$ $${500.75}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${+0}$$ $${6190.04}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${+0.17}$$ $${6311.68}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${-0}$$ $${1627.9}$$ < $${1628.16}$$ $${+0}$$ $${543.03}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.84}$$ < $${213.79}$$ $${-0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${-0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0.08}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${+0.09}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0.08}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0.08}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0.24}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0.23}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${-0}$$ $${11.2}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0.25}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0.23}$$ $${11.16}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0.25}$$ $${12.86}$$ < $${13.81}$$

@astuyve
Copy link
Contributor Author
astuyve commented Jun 16, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Jun 16, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-16 10:37:08 UTC ℹ️ Start processing command /merge

2025-06-16 10:37:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-16 11:18:10 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a95af0e into main Jun 16, 2025
229 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aj/fix-metrics-tests branch June 16, 2025 11:18
@github-actions github-actions bot modified the milestones: Triage, 7.69.0 Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/serverless
Projects
None yet
Milestone
7.69.0
Development

Successfully merging this pull request may close these issues.
2 participants
@astuyve @duncanista
0