8000 [EBPF] kmt: improve fuzzy matching for VM names by gjulianm · Pull Request #36968 · DataDog/datadog-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[EBPF] kmt: improve fuzzy matching for VM names #36968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[EBPF] kmt: improve fuzzy matching for VM names #36968

wants to merge 3 commits into from
+77 −7

Conversation

gjulianm
Copy link
Contributor
@gjulianm gjulianm commented May 14, 2025 •
edited
Loading

What does this PR do?

This PR updates the way we generate possible fuzzy matching candidates:

  • Stop generating candidates for architectures that don't exist. This could cause confusing errors if the user entered a name that matched an existing OS but with an unsupported architecture (e.g., Ubuntu 16 is supported only for x64, so distro-ubuntu_16.04-arm64 would show a KeyError with no further explanation).
  • Allow selecting OSs with only the minor version and without underscore (e.g., ubuntu22-arm64-distro would not correctly select ubuntu22).
  • Also adds unit tests to ensure we don't regress in our behavior.

Motivation

Make it easier to select distros.

Describe how you validated your changes

Unit tests added.

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this May 14, 2025
@github-actions github-actions bot added team/ebpf-platform short review PR is simple enough to be reviewed quickly labels May 14, 2025
@gjulianm gjulianm added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels May 14, 2025
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels May 14, 2025
@agent-platform-auto-pr
Copy link
Contributor
agent-platform-auto-pr bot commented May 14, 2025 •
edited
Loading

Gitlab CI Configuration Changes

Modified Jobs

invoke_unit_tests 
  invoke_unit_tests:
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-17-x64$CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX:$CI_IMAGE_LINUX_GLIBC_2_17_X64
    needs: []
    rules:
    - if: $CI_COMMIT_BRANCH == "main"
    - changes:
        compare_to: $COMPARE_TO_BRANCH
        paths:
        - tasks/**/*
    script:
    - python3 -m pip install "git+https://github.com/DataDog/datadog-agent-dev.git@v$(cat
      .dda/version)" --break-system-packages
-   - python3 -m dda self dep sync -f legacy-tasks
+   - python3 -m dda self dep sync -f legacy-tasks -f legacy-kernel-matrix-testing
?                                                 ++++++++++++++++++++++++++++++++
    - dda inv -- -e invoke-unit-tests.run
    stage: source_test
    tags:
    - arch:amd64

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor
agent-platform-auto-pr bot commented May 14, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor d2e24cc71bb2c442861e9a27cb97af2777936580

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 773.30MB 773.30MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 782.25MB 782.25MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 782.25MB 782.25MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 759.26MB 759.26MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 768.19MB 768.19MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.47MB 30.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 380.12MB 380.12MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.70MB 62.70MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.78MB 62.78MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.78MB 62.78MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.35MB 59.35MB 0.50MB

Decision

✅ Passed

@cit-pr-commenter cit-pr-commenter
Copy link
cit-pr-commenter bot commented May 14, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 67362e6e-ba29-41d5-bcfa-756568d0da7a

Baseline: 03f984c
Comparison: 643e3f1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.88 [-1.08, +4.85] 1 Logs
➖ ddot_logs memory utilization +0.47 [+0.36, +0.59] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.31 [+0.14, +0.48] 1 Logs
➖ otlp_ingest_logs memory utilization +0.31 [+0.18, +0.44] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.22 [+0.16, +0.28] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.10 [-0.51, +0.70] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.08 [-0.53, +0.68] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.52, +0.55] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.54, +0.54] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.27] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.62, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.02 [-0.26, +0.22] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.05 [-0.61, +0.50] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.60, +0.47] 1 Logs
➖ ddot_metrics memory utilization -0.17 [-0.29, -0.05] 1 Logs
➖ docker_containers_memory memory utilization -0.24 [-0.28, -0.19] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.32 [-0.40, -0.25] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.36 [-0.42, -0.30] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.48 [-0.53, -0.43] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.68 [-1.55, +0.18] 1 Logs
➖ file_tree memory utilization -0.89 [-1.04, -0.74] 1 Logs
➖ quality_gate_logs % cpu utilization -2.48 [-5.24, +0.27] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor
agent-platform-auto-pr bot commented May 14, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 03f984c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${697.0}$$ < $${697.37}$$ $${-0}$$ $${176.09}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${0}$$ $${695.3}$$ < $${695.59}$$ $${-0}$$ $${175.55}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${-0}$$ $${96.51}$$ < $${97.47}$$
✅ agent_msi $${0}$$ $${958.88}$$ < $${959.86}$$ $${-0.01}$$ $${146.29}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${0}$$ $${696.99}$$ < $${697.36}$$ $${+0.03}$$ $${177.68}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${0}$$ $${695.29}$$ < $${695.58}$$ $${+0}$$ $${177.53}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${0}$$ $${687.02}$$ < $${687.37}$$ $${+0.02}$$ $${161.07}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${0}$$ $${685.43}$$ < $${685.72}$$ $${+0.01}$$ $${160.25}$$ < $${161.11}$$
✅ agent_suse_amd64 $${0}$$ $${696.99}$$ < $${697.36}$$ $${+0.03}$$ $${177.68}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${0}$$ $${695.29}$$ < $${695.58}$$ $${+0}$$ $${177.53}$$ < $${178.43}$$
✅ agent_suse_arm64 $${0}$$ $${687.02}$$ < $${687.37}$$ $${+0.02}$$ $${161.07}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${0}$$ $${685.43}$$ < $${685.72}$$ $${+0.01}$$ $${160.25}$$ < $${161.11}$$
✅ docker_agent_amd64 $${+0}$$ $${780.79}$$ < $${781.16}$$ $${-0}$$ $${268.79}$$ < $${269.63}$$
✅ docker_agent_arm64 $${0}$$ $${794.27}$$ < $${794.62}$$ $${-0.01}$$ $${256.13}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${-0}$$ $${971.99}$$ < $${972.35}$$ $${+0}$$ $${337.76}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${974.06}$$ < $${974.41}$$ $${+0}$$ $${321.07}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${+0.47}$$ $${1487.02}$$ < $${1488.0}$$ $${+0.49}$$ $${488.0}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6216.98}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${+22.32}$$ $${6360.87}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.65}$$ < $${1609.5}$$ $${-0.05}$$ $${530.27}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${-0.31}$$ $${1506.18}$$ < $${1507.0}$$ $${-0.02}$$ $${500.74}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${+0}$$ $${6190.07}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${-0}$$ $${6311.68}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${+0.13}$$ $${1628.04}$$ < $${1628.16}$$ $${-0}$$ $${543.03}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${0}$$ $${212.84}$$ < $${213.79}$$ $${+0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${-0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${+0.01}$$ $${11.21}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$

@gjulianm gjulianm force-pushed the guillermo.julian/improve-kmt-fuzzy-matching branch 2 times, most recently from 60afc55 to 1249ba4 Compare May 21, 2025 11:57
@gjulianm gjulianm force-pushed the guillermo.julian/improve-kmt-fuzzy-matching branch from 1249ba4 to 643e3f1 Compare June 16, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gjulianm gjulianm

Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gjulianm
0