frr: add FRR dplane plugin #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
172b42c to
7829dc0
Compare
rjarry
requested changes
May 19, 2025
0c23fa1 to
4e27747
Compare
2cc8146 to
547f4e6
Compare
rjarry
requested changes
May 27, 2025
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
e16bd58 to
28ce398
Compare
vjardin
suggested changes
May 27, 2025
rjarry
requested changes
May 27, 2025
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
subprojects/packagefiles/frr/meson-add-dependency-definition.patch
Outdated
Show resolved
Hide resolved
rjarry
reviewed
May 27, 2025
rjarry
reviewed
May 27, 2025
rjarry
reviewed
May 27, 2025
50e4412 to
99af48e
Compare
|
LGTM |
9e9f871 to
0217625
Compare
This patch adds support for building a zebra plugin out-of-tree, using
FRR as a Meson subproject. The plugin is compiled against FRR’s headers
as a shared module.
The plugin integrates Grout with FRR using the dplane plugin API.
It supports:
- Synchronization of routes and addresses from FRR to Grout.
- Synchronization of interfaces, routes, and addresses from Grout to FRR.
Key changes:
- Adds FRR as a subproject under subprojects/frr (wrap-git).
- New Meson feature option `-Dfrr` to enable or auto-detect the plugin.
- Bootstraps and builds FRR with most daemons disabled for a tiny tree.
- Declares `frr_dep` for **access to FRR headers and build variables**
(no direct linkage to libfrr).
- **Helper script `frr_install.sh` installs FRR runtime files inside the
private prefix**:
* copies `frr.conf`, `daemons`, and optional `vtysh.conf` /
`watchfrr.conf`;
* creates log and state directories;
* appends a `--log file:$prefix/var/log/frr/zebra.log` option in
`daemons`.
- Adds `licenses/GPL-2.0-or-later.txt` and updates the project license
string to `BSD-3-Clause AND GPL-2.0-or-later` to reflect the plugin.
- Extends CI: one matrix job builds with `-Dfrr=enabled` and pulls extra
FRR build dependencies.
- Smoke tests: infrastructure now detects `-Dfrr=enabled`; a new
`ip_forward_frr_test.sh` validates end-to-end routing via the plugin.
This structure allows FRR plugin development and testing without
modifying the FRR source tree directly.
Signed-off-by: Maxime Leroy <maxime@leroys.fr>
rjarry
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for building a zebra plugin out-of-tree, using FRR as a Meson subproject. The plugin is compiled as a shared module and linked against libfrr, using FRR's headers.
The plugin integrates Grout with FRR using the dplane plugin API. It supports:
Key changes:
frr_depfor linking against libfrr and using its includesThis structure allows FRR plugin development and testing without modifying the FRR source tree directly.
TODO: add FRR wraper to install on system, check how to run in a smoke test, check that plugin is working properly etc ...