Frr integration #205
Merged
Frr integration #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values were taken from FRR. We only need them for display purposes in the CLI. Link: https://github.com/FRRouting/frr/blob/frr-10.3/zebra/rt_netlink.h#L36 Signed-off-by: Maxime Leroy <maxime@leroys.fr>
To support FRR, interfaces created or deleted in Grout must be synchronized with FRR. FRR listens for interface notifications from Grout to keep its internal state consistent. When FRR receives an IFACE_EVENT_PRE_REMOVE notification, the dplane plugin in FRR attempts to remove the corresponding interface from memory. How 7168 ever, Zebra fails to delete it if the interface is still marked as "up". In the Linux kernel, when an interface is deleted, a netlink message is first sent to indicate that the interface is down. Grout should follow the same behavior. Signed-off-by: Maxime Leroy <maxime@leroys.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few small enhancement to support FRR.