8000 CI unit tests and full python 3.5 compatibility by Almenon · Pull Request #6 · Duroktar/Wolf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI unit tests and full python 3.5 compatibility #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 2, 2018

Conversation

Almenon
Copy link
Contributor
@Almenon Almenon commented Mar 2, 2018

This addresses #5 and #2

I just added two unit tests so there is a lot more work that could be done for #5

Important note on the build status badge: You will need to modify it once you merge v0.2.0pre into main to point to main. I also suggest getting a travis account (simple and free) and pointing the badge to your account rather than mine.

Random question: how the heck do you debug result_handler? Breakpoints set in it don't work :/

@Duroktar
Copy link
Owner
Duroktar commented Mar 2, 2018

Hey bud, sorry for the delay, I'm starting up a new job soon and have been burning the candle at [1:-1].

Anyway, first of all I want to thank you for helping out and just for being interested in the project, I think that's awesome! I'm pretty glad you found the 0.2.0pre branch because that's where I've been focusing.

So, in a little bit I'll give your PR a look through and probably merge it right away. I'm especially interested in the test cases you wrote because I've been putting that part off due to laziness; good stuff, thank you :) And thanks for letting me know about the Badge, I'll be sure to change that.

As for debugging result_handler, funny enough I use Wolf and modify the if __name__ == '__main__': block to point to the test.py file in the script directory.

I found the hunter docs to be the most helpful though, and rarely had to debug the wolf.py file at all (except before I got rid of macros, that was hard and probably since I couldn't debug it like you mentioned, is the reason why I got rid of them).

BTW: I have another update that I planned on pushing today that enables live reloading! I'll try to merge your stuff first though so you don't have to refactor anything if need be.

Cheers

@Duroktar Duroktar added the enhancement New feature or request label Mar 2, 2018
@Duroktar Duroktar self-requested a review March 2, 2018 17:01
Copy link
Owner
@Duroktar Duroktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again 💯

@Duroktar Duroktar merged commit f57862c into Duroktar:v0.2.0pre Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0