8000 fix(Token Generator): multi token, last settings, length input, denied chars by sharevb · Pull Request #913 · CorentinTh/it-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(Token Generator): multi token, last settings, length input, denied chars #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

sharevb
Copy link
Contributor
@sharevb sharevb commented Mar 3, 2024

Copy link
vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Sep 22, 2024 5:05pm

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

lemon8866 added a commit to lemon8866/it-tools that referenced this pull request Jul 26, 2024
PR Author By@sharevb
@sharevb sharevb force-pushed the fix/token-generator branch from 896a9bb to 8881f44 Compare August 3, 2024 12:48
Copy link
sonarqubecloud bot commented Aug 3, 2024

@sharevb sharevb changed the title fix(Token Generator): multi token, last settings, length input fix(Token Generator): multi token, last settings, length input, denied chars Aug 3, 2024
@sharevb
Copy link
Contributor Author
sharevb commented Sep 21, 2024

Hi @steffenrapp, may be interested in reviewing this one :) ?

@steffenrapp
< 8000 details class="details-overlay details-reset position-relative d-inline-block"> Copy link
Contributor

Hi @sharevb I tested it and it works fine. Also looks good on mobile - also better than the current version.
The only problem is that you can enter 0 and negative values in both the length and the number of tokens. I think the minimum should be 1 for both? Also, the tool crashes (disappears) when you enter negative length and positive number of tokens.
Bildschirmfoto 2024-09-21 um 15 05 28

Copy link

@sharevb
Copy link
Contributor Author
sharevb commented Sep 22, 2024

Hi @sharevb I tested it and it works fine. Also looks good on mobile - also better than the current version. The only problem is that you can enter 0 and negative values in both the length and the number of tokens. I think the minimum should be 1 for both? Also, the tool crashes (disappears) when you enter negative length and positive number of tokens.

Hi @steffenrapp, should be ok now

@steffenrapp
Copy link
Contributor

Hi @sharevb awesome! Everything fine now from my perspective.

@sharevb
Copy link
Contributor Author
sharevb commented Nov 24, 2024
< 783C tbody class="d-block">

Hi, for people interested in up to date version of it-tools, I made kind of a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TOOL IMPROVEMENT] Token Generator to generate multiple tokens/passwords
2 participants
0