8000
feat(view-note): prevent note password auto-completion from auth password by dhenry123 · Pull Request #389 · CorentinTh/enclosed · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring the enclosed instance with user authentication
Log in to application (login/password) and save info in Firefox
When you reach the note creation page, the password is automatically filled in with the password of the logged-in user.
This PR proposes adding the autocomplete=“new-password” attribute to inputs of type “password” on the page: packages/app-client/src/modules/notes/pages/view-note.page.tsx and in the component :
packages/app-client/src/modules/notes/components/note-password-field.tsx
CorentinTh
changed the title
UI : autocomplete=new-password for note creation and view page
feat(view-note): prevent note password auto-completion from auth password
Jan 27, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case reproduction:
This PR proposes adding the autocomplete=“new-password” attribute to inputs of type “password” on the page: packages/app-client/src/modules/notes/pages/view-note.page.tsx and in the component :
packages/app-client/src/modules/notes/components/note-password-field.tsx
These changes fix this autocompletion problem.
Thank you for your work