8000 Make the srg_group.xml work again by isimluk · Pull Request #5100 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make the srg_group.xml work again #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 9, 2020
Merged

Make the srg_group.xml work again #5100

merged 6 commits into from
Jan 9, 2020

Conversation

isimluk
Copy link
Member
@isimluk isimluk commented Jan 9, 2020

A picture is worth 1000 words

scrot

See also tables/table-rhel7-srgmap-flat.html.

Overview

This re-implements SRG overlay.

SRG overlays have been broken since the repo was converted from the shorthand
format. This brings the support for overlays/srg_support.xml back to the game.

Overlay is used to generate more complete SRG Mapping table. The mapping tables
provides overview how the SRG requirements are implemented in scope of the
product.

@isimluk
Re-implement SRG overlay
2bab453 
SRG overlays have been broken since the repo was converted from the shorthand
format. This brings the support for overlays/srg_support.xml back to the game.

Overlay is used to generate more complete SRG Mapping table. The mapping tables
provides overview how the SRG requirements are implemented in scope of the
product.
isimluk added 4 commits January 9, 2020 14:44
@isimluk
Show status=N/A when using overlay Rule to map given SRG
a996576
@isimluk
Do not show leading colon for overlayed rules
2ff507b 
(when CCE is not available).
@isimluk
Provide SRG overlay file for RHEL 8
176f087
@isimluk
Provide empty overlay file for EAP6
4b6ec54 
So, we can require the file to exists in the CMake macro. Requiring file in the
CMake macro explicitly may ease debugging for products that define it; should
some problem occur in future.
@isimluk isimluk mentioned this pull request Jan 9, 2020
Merged
@isimluk
Use 'Applicable - Inherently Meets' language in the srgmap
b0b0776 
Don't know exactly yet what recognized statuses are, but I just saw this one. So
let's use it.
shawndwells
shawndwells approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member
@shawndwells shawndwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Appreciate the annotated image too.

Not worrying about the <ref disa=...> mappings at this time. Lets get the functionality working and incrementally address data quality issues.

@shawndwells shawndwells merged commit f046f8b into ComplianceAsCode:master Jan 9, 2020
@shawndwells shawndwells added this to the 0.1.48 milestone Jan 9, 2020
@isimluk
Copy link
Member Author
isimluk commented Jan 9, 2020

Thanks!

@yuumasato yuumasato modified the milestones: 0.1.48, 0.1.49 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawndwells shawndwells shawndwells approved these changes

@tedbrunell tedbrunell Awaiting requested review from tedbrunell

Assignees

@shawndwells shawndwells

Labels
None yet
Projects
None yet
Milestone
0.1.48
Development

Successfully merging this pull request may close these issues.
3 participants
@isimluk @shawndwells @yuumasato
0