8000 Refactor & clean-up & tidy-up the ansible roles generator by isimluk · Pull Request #5741 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor & clean-up & tidy-up the ansible roles generator #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 6, 2020
Merged

Refactor & clean-up & tidy-up the ansible roles generator #5741

Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0b494d5
Refactor: Make _update_content_if_needed generic and re-usable
isimluk May 4, 2020
6a37cd4
Refactor: Replace _update_vars_contetn_if_needed by generic method
isimluk May 4, 2020
88f7eaf
Refactor: replace _update_readme_content_if_needed by generic method
isimluk May 4, 2020
085cc10
Refactor: replace _update_meta_content_if_needed by generic method
isimluk May 5, 2020
95955bd
Get a rid of repo_status variable, it is no longer needed
isimluk May 5, 2020
182585a
Refactor: replace add_task_variables_to_default_variables_if_needed b…
isimluk May 5, 2020
0b23e94
Refactor: Consolidate Role class initialization
isimluk May 5, 2020
46dde11
Refactor: Consolidate description handling to a single place
isimluk May 5, 2020
0dc38a1
Refactor: Extract class PlaybookToRoleConverter
isimluk May 5, 2020
c539995
Remove overabundant variable, not used
isimluk May 5, 2020
9ea2f23
Refactor: Move defaults variable handling up to the converter class
isimluk May 5, 2020
d8f1b25
Refactor: simplify logic so that my eyes stop bleeding
isimluk May 5, 2020
f5d1619
Refactor: Move task_local_content down to the ansible converter
isimluk May 5, 2020
60eaffa
Refactor: Move all the other post-processing down to the convertor class
isimluk May 5, 2020
c8462e2
Refactor: Replace variable by memoized property
isimluk May 6, 2020
c0c1e78
Remove instance variables that are no longer needed
isimluk May 6, 2020
bf4575f
Replace tasks_data variable by memoized property
isimluk May 6, 2020
a3ad7e0
Refactor: Replace instance variable with cached property
isimluk May 6, 2020
0ba4c4d
Refactor: Extract property: description_md
isimluk May 6, 2020
7fc5b90
Refactor: Replace instance variable with cached property
isimluk May 6, 2020
3248e10
Refactor: Extract property: _raw_playbook
isimluk May 6, 2020
9f1124b
Refactor: consolidate description handling to a single place
isimluk May 6, 2020
508f76d
Refactor: Replace instance variable with memoized property
isimluk May 6, 2020
d6a32d2
Refactor: Replace instance variable with memoized property
isimluk May 6, 2020
8717719
Refactor: Consolidate and simplify added_variables processing
isimluk May 6, 2020
db4f43f
Get a rid of some unneeded variables at the Role class
isimluk May 6, 2020
888b5c3
Refactor: Expand method
isimluk May 6, 2020
b78597a
Refactor: Extract const
isimluk May 6, 2020
884b9fa
Rename class to enable reader orient themselves better
isimluk May 6, 2020
25acf9b
Move new file generation to the AnsiblePlaybookToRoleConverter
isimluk May 6, 2020
78c2057
Commit sha is needed for updating remote repo
isimluk May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
0