Stop processing templated remediations by Jinja #13471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remediations that were generated from templates already have all Jinja code resolved. Therefore, it isn't necessary to process them with Jinja for the second time. In `collect_remediations.py`, we will process with Jinja only static remediations and we will not process with Jinja the generated remediations. This will speed the build up because there are many remediations generated from templates and Jinja processing takes a lot of time. As a part of this change we will rename all `parse_from_file_with_jinja` methods in `Remediation` and subclasses.
|
Code Climate has analyzed commit 98c1904 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 88.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
vojtapolasek
approved these changes
May 16, 2025
|
Just fyi, I did some quick tests. |
98f1d65
into
ComplianceAsCode:master
106 of 109 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediations that were generated from templates already have all Jinja code resolved. Therefore, it isn't necessary to process them with Jinja for the second time. In
collect_remediations.py, we will process with Jinja only static remediations and we will not process with Jinja the generated remediations. This will speed the build up because there are many remediations generated from templates and Jinja processing takes a lot of time.As a part of this change we will rename all
parse_from_file_with_jinjamethods inRemediationand subclasses.