Remove superfluous TSs from grub2_audit_backlog_limit_argument #13452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes static test scenarios from rule `grub2_audit_backlog_limit_argument` because this rule is templated and the functionality is already tested by templated test scenarios. Moreover, the static test scenarios are incomplete. For example: `correct_grubenv.pass.sh` currently fails because the test doesn't edit `/etc/default/grub` but the OVAL requires that the setting is present in `/etc/default/grub`.
|
Code Climate has analyzed commit d23c389 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
ggbecker
approved these changes
May 12, 2025
|
Removal of tests do not impose any risk of running undesired code. Bypassing the merge rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes static test scenarios from rule
grub2_audit_backlog_limit_argumentbecause this rule is templated and the functionality is already tested by templated test scenarios. Moreover, the static test scenarios are incomplete. For example:correct_grubenv.pass.shcurrently fails because the test doesn't edit/etc/default/grubbut the OVAL requires that the setting is present in/etc/default/grub.