8000 Format thin data streams by jan-cerny · Pull Request #13416 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Format thin data streams #13416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Format thin data streams #13416

merged 1 commit into from
Apr 30, 2025

Conversation

jan-cerny
Copy link
Collaborator
@jan-cerny jan-cerny commented Apr 30, 2025 •
edited
Loading

This prevents building data streams that contain very long lines because openscap has problems parsings them and segfaults or prints errors.
It will be executed only when the elementtree library doesn't contain the inden 8000 t method which means when building with Python older that 3.9.

Review Hints:

On RHEL 8, run ./build_product -t rhel8. You need to build it on RHEL 8 machine because of the Python. Check in CMake stdout that Python 3.6 is used for building.

vim build/thin_ds/ssg-rhel8-ds_accounts_umask_etc_bashrc.xml
oscap xccdf eval --profile '(all)' build/thin_ds/ssg-rhel8-ds_accounts_umask_etc_bashrc.xml

@jan-cerny
Format thin data streams
29238a7 
This prevents building data streams that contain very long lines
because openscap has problems parsings them and segfaults or
prints errors.
It will be executed only when the elementtree library doesn't
contain the indent method which means when building with Python
older that 3.9.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 30, 2025
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Apr 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jan-cerny jan-cerny added this to the 0.1.77 milestone Apr 30, 2025
@jan-cerny jan-cerny added the Infrastructure Our content build system label Apr 30, 2025
@jan-cerny jan-cerny marked this pull request as ready for review April 30, 2025 15:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 30, 2025
@codeclimate CodeClimate
Copy link
codeclimate bot commented Apr 30, 2025

Code Climate has analyzed commit 29238a7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Apr 30, 2025
@Mab879 Mab879 merged commit b969533 into ComplianceAsCode:master Apr 30, 2025
109 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Infrastructure Our content build system
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-cerny @Mab879
0