rsyslog_remote_loghost: support Rainer Script in OVAL #13274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost'.
--- xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost
+++ xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost
@@ -19,13 +19,22 @@
*.* @'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'
+Or in RainerScript:
+*.* action(type="omfwd" ... target="'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'" protocol="udp")
+
To use TCP for log message delivery:
*.* @@'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'
+Or in RainerScript:
+*.* action(type="omfwd" ... target="'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'" protocol="tcp")
+
To use RELP for log message delivery:
*.* :omrelp:'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'
+
+Or in RainerScript:
+*.* action(type="omfwd" ... target="'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'" protocol="relp")
There must be a resolvable DNS CNAME or Alias record set to "'xccdf_org.ssgproject.content_value_rsyslog_remote_loghost_address'" for logs to be sent correctly to the centralized logging utility.
@@ -44,6 +53,9 @@
$ActionQueueSaveOnShutdown on
$ActionResumeRetryCount -1
+Or if using Rainer Script syntax, it could be:
+*.* action(type="omfwd" queue.type="linkedlist" queue.filename="example_fwd" action.resumeRetryCount="-1" queue.saveOnShutdown="on" target="example.com" port="30514" protocol="tcp")
+
[reference]:
1
OVAL for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost' differs.
--- oval:ssg-rsyslog_remote_loghost:def:1
+++ oval:ssg-rsyslog_remote_loghost:def:1
@@ -1,3 +1,5 @@
criteria OR
criterion oval:ssg-test_remote_rsyslog_conf:tst:1
criterion oval:ssg-test_remote_rsyslog_d:tst:1
+criterion oval:ssg-test_remote_rsyslog_conf_rainer:tst:1
+criterion oval:ssg-test_remote_rsyslog_d_rainer:tst:1
OCIL for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost' differs.
--- ocil:ssg-rsyslog_remote_loghost_ocil:questionnaire:1
+++ ocil:ssg-rsyslog_remot
8000
e_loghost_ocil:questionnaire:1
@@ -2,9 +2,15 @@
/etc/rsyslog.conf.
If using UDP, a line similar to the following should be present:
*.* @
+or
+*.* action(type="omfwd" ... target="" protocol="udp")
If using TCP, a line similar to the following should be present:
*.* @@
+or
+*.* action(type="omfwd" ... target="" protocol="tcp")
If using RELP, a line similar to the following should be present:
*.* :omrelp:
+or
+*.* action(type="omfwd" ... target="" protocol="relp")
Is it the case that no evidence that the audit logs are being off-loaded to another system or media?
|
|
Code Climate has analyzed commit 79cd474 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
The TSs have run locally and pass:
jcerny@fedora:~/work/git/scap-security-guide (pr/13274)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel10 rsyslog_remote_loghost
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-04-02-1606/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost
INFO - Script line_commented.fail.sh using profile (all) OK
INFO - Script line_not_there.fail.sh using profile (all) OK
INFO - Script remote_configured.pass.sh using profile (all) OK
INFO - Script remote_configured_rainer.pass.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/13274)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel10 --remediate-using ansible rsyslog_remote_loghost
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-04-02-1607/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_rsyslog_remote_loghost
INFO - Script line_commented.fail.sh using profile (all) OK
INFO - Script line_not_there.fail.sh using profile (all) OK
INFO - Script remote_configured.pass.sh using profile (all) OK
INFO - Script remote_configured_rainer.pass.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
fixes: OPENSCAP-5467
Review Hints: